[PR #2525] fix(i18n): mark billing messages for translation #2368

Open
opened 2026-02-26 20:33:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2525
Author: @mKoonrad
Created: 2/21/2026
Status: 🔄 Open

Base: mainHead: settings-billing-for-translation


📝 Commits (1)

  • 68869d6 fix(i18n): mark billing messages for translation

📊 Changes

1 file changed (+52 additions, -26 deletions)

View changed files

📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.billing.tsx (+52 -26)

📄 Description

Description

I marked missing billing strings for translation. Currently, these strings are untranslated and have complex logic of combining parts of sentences. I created full single sentences and marked these with Trans tag.

Original is not the simplest logic, so I hope that I have proposed one of more readable solution.

Changes Made

  • Mark strings to translate

Testing Performed

  • npm run build
  • Check web.po file

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2525 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 2/21/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `settings-billing-for-translation` --- ### 📝 Commits (1) - [`68869d6`](https://github.com/documenso/documenso/commit/68869d677d38682fa2fa0771f7d4e615c0108f4a) fix(i18n): mark billing messages for translation ### 📊 Changes **1 file changed** (+52 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.billing.tsx` (+52 -26) </details> ### 📄 Description ## Description I marked missing billing strings for translation. Currently, these strings are untranslated and have complex logic of combining parts of sentences. I created full single sentences and marked these with `Trans` tag. Original is not the simplest logic, so I hope that I have proposed one of more readable solution. ## Changes Made - Mark strings to translate ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2368
No description provided.