[PR #2514] [MERGED] fix(i18n): mark strings inside div for translation #2356

New issue

Closed

opened 2026-02-26 20:33:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2514
Author: @mKoonrad
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @Mythie

Base: main ← Head: mark-div-for-translation

📝 Commits (1)

02e7f1d fix(i18n): mark div strings for translation

📊 Changes

6 files changed (+37 additions, -6 deletions)

View changed files

📝 apps/remix/app/components/general/billing-plans.tsx (+3 -1)
📝 apps/remix/app/components/general/user-profile-skeleton.tsx (+1 -1)
📝 apps/remix/app/routes/embed+/_v0+/_layout.tsx (+6 -1)
📝 apps/remix/app/routes/embed+/v1+/authoring+/_layout.tsx (+6 -1)
📝 packages/ui/components/pdf-viewer/pdf-viewer-konva-lazy.tsx (+8 -1)
📝 packages/ui/primitives/pdf-viewer/lazy.tsx (+13 -1)

📄 Description

Description

I marked missing strings inside div for translation.

Changes Made

Mark strings to translate

Testing Performed

npm run build
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2514 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `mark-div-for-translation` --- ### 📝 Commits (1) - [`02e7f1d`](https://github.com/documenso/documenso/commit/02e7f1db9aeb3fd0d37c1e45b78eabf7be36e890) fix(i18n): mark div strings for translation ### 📊 Changes **6 files changed** (+37 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/billing-plans.tsx` (+3 -1) 📝 `apps/remix/app/components/general/user-profile-skeleton.tsx` (+1 -1) 📝 `apps/remix/app/routes/embed+/_v0+/_layout.tsx` (+6 -1) 📝 `apps/remix/app/routes/embed+/v1+/authoring+/_layout.tsx` (+6 -1) 📝 `packages/ui/components/pdf-viewer/pdf-viewer-konva-lazy.tsx` (+8 -1) 📝 `packages/ui/primitives/pdf-viewer/lazy.tsx` (+13 -1) </details> ### 📄 Description ## Description I marked missing strings inside div for translation. ## Changes Made - Mark strings to translate ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:32 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2356

No description provided.

Rows
Columns