[PR #2509] [MERGED] fix: v2 embed direct templates not reading email/lockEmail from hash params #2354

New issue

Closed

opened 2026-02-26 20:33:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2509
Author: @Mythie
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @dguyen

Base: main ← Head: fix/embed-direct-template-email-prefill

📝 Commits (1)

2e52e51 fix: pass email and lockEmail from embed hash params to v2 signing flow

📊 Changes

1 file changed (+15 additions, -1 deletions)

View changed files

📝 apps/remix/app/components/embed/embed-document-signing-page-v2.tsx (+15 -1)

📄 Description

Summary

The v2 signing page (EmbedSignDocumentV2ClientPage) wasn't reading email or lockEmail from the embed hash params for direct template flows. This meant:

The email passed by the embed SDK was silently ignored, so the completion dialog always showed an empty email field
Since isEmailLocked was never explicitly passed to the EmbedSigningProvider, it defaulted to true — so as soon as a user typed a single character the field locked, leaving them stuck with an invalid email and no way to complete signing

Reported externally and tracked in #2258.

Changes

Read email and lockEmail from hash params for TEMPLATE type envelopes and apply them to state
Pass isEmailLocked through to EmbedSigningProvider
Default isEmailLocked to true for DOCUMENT types (email is server-provided) and false for TEMPLATE types (email comes from the embed hash)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2509 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/embed-direct-template-email-prefill` --- ### 📝 Commits (1) - [`2e52e51`](https://github.com/documenso/documenso/commit/2e52e51d5bf3563c0b1d41518346879e02d4f75e) fix: pass email and lockEmail from embed hash params to v2 signing flow ### 📊 Changes **1 file changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/embed/embed-document-signing-page-v2.tsx` (+15 -1) </details> ### 📄 Description ## Summary The v2 signing page (`EmbedSignDocumentV2ClientPage`) wasn't reading `email` or `lockEmail` from the embed hash params for direct template flows. This meant: - The email passed by the embed SDK was silently ignored, so the completion dialog always showed an empty email field - Since `isEmailLocked` was never explicitly passed to the `EmbedSigningProvider`, it defaulted to `true` — so as soon as a user typed a single character the field locked, leaving them stuck with an invalid email and no way to complete signing Reported externally and tracked in #2258. ## Changes - Read `email` and `lockEmail` from hash params for `TEMPLATE` type envelopes and apply them to state - Pass `isEmailLocked` through to `EmbedSigningProvider` - Default `isEmailLocked` to `true` for `DOCUMENT` types (email is server-provided) and `false` for `TEMPLATE` types (email comes from the embed hash) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:31 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2354

No description provided.

Rows
Columns