[PR #2494] [MERGED] fix(i18n): mark span strings for translation #2342

New issue

Closed

opened 2026-02-26 20:33:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2494
Author: @mKoonrad
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @dguyen

Base: main ← Head: mark-span-for-translation

📝 Commits (1)

9c93a69 fix(i18n): mark span strings for translation

📊 Changes

12 files changed (+68 additions, -19 deletions)

View changed files

📝 apps/remix/app/components/embed/embed-client-loading.tsx (+4 -1)
📝 apps/remix/app/components/embed/embed-direct-template-client-page.tsx (+3 -1)
📝 apps/remix/app/components/embed/embed-document-signing-page-v1.tsx (+3 -1)
📝 apps/remix/app/components/general/document-signing/document-signing-mobile-widget.tsx (+3 -1)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx (+3 -1)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-fields-page.tsx (+16 -4)
📝 apps/remix/app/routes/_authenticated+/admin+/organisations.$id.tsx (+3 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx (+3 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates.folders._index.tsx (+3 -1)
📝 apps/remix/app/routes/embed+/v1+/multisign+/_index.tsx (+7 -2)
📝 packages/ui/components/document/envelope-recipient-field-tooltip.tsx (+3 -1)
📝 packages/ui/primitives/document-flow/field-item.tsx (+17 -4)

📄 Description

Description

I marked missing span strings for translation.

Changes Made

Mark strings to translate

Testing Performed

npm run build
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2494 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `mark-span-for-translation` --- ### 📝 Commits (1) - [`9c93a69`](https://github.com/documenso/documenso/commit/9c93a69124758af5233d068c8703f55c4d52f4ad) fix(i18n): mark span strings for translation ### 📊 Changes **12 files changed** (+68 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/embed/embed-client-loading.tsx` (+4 -1) 📝 `apps/remix/app/components/embed/embed-direct-template-client-page.tsx` (+3 -1) 📝 `apps/remix/app/components/embed/embed-document-signing-page-v1.tsx` (+3 -1) 📝 `apps/remix/app/components/general/document-signing/document-signing-mobile-widget.tsx` (+3 -1) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx` (+3 -1) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-fields-page.tsx` (+16 -4) 📝 `apps/remix/app/routes/_authenticated+/admin+/organisations.$id.tsx` (+3 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx` (+3 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates.folders._index.tsx` (+3 -1) 📝 `apps/remix/app/routes/embed+/v1+/multisign+/_index.tsx` (+7 -2) 📝 `packages/ui/components/document/envelope-recipient-field-tooltip.tsx` (+3 -1) 📝 `packages/ui/primitives/document-flow/field-item.tsx` (+17 -4) </details> ### 📄 Description ## Description I marked missing span strings for translation. ## Changes Made - Mark strings to translate ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2342

No description provided.

Rows
Columns