[PR #2481] [CLOSED] fix: highlight rejected certificate text and use correct audit logs #2335

New issue

Closed

opened 2026-02-26 20:33:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2481
Author: @Copilot
Created: 2/12/2026
Status: ❌ Closed

Base: fix/highlight-rejected-certificate-text ← Head: copilot/sub-pr-2478

📝 Commits (1)

46d712f Initial plan

📄 Description

Description

Rejected recipients in signing certificate PDFs were visually indistinguishable from completed recipients, and their IP/Device fields displayed "Unknown" despite rejection audit logs containing this data.

Changes:

Added red text highlighting (#dc2626) for rejected status in Details column
Modified renderLabelAndText to support custom labelFill and valueFill colors
Hide signature container for rejected recipients
Use recipient.logs.rejected audit log for IP Address/Device fields when recipient is rejected (falls back to completed otherwise)
Updated audit log generation to include completed audit logs in document sealing

Before:
Rejected status displayed in default gray color with "Unknown" IP/Device values, making rejections easy to miss.

After:
Rejected status renders in red with accurate IP Address and Device information from rejection audit log.

// IP/Device now use the appropriate audit log source
const relevantLog = isRejected ? recipient.logs.rejected : recipient.logs.completed;

const ipLabelAndText = renderLabelAndText({
  label: i18n._(msg`IP Address`),
  text: relevantLog?.ipAddress ?? i18n._(msg`Unknown`),
  width,
});

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2481 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 2/12/2026 **Status:** ❌ Closed **Base:** `fix/highlight-rejected-certificate-text` ← **Head:** `copilot/sub-pr-2478` --- ### 📝 Commits (1) - [`46d712f`](https://github.com/documenso/documenso/commit/46d712f4cc6b9574dd1d50d600c1cf8c7d7a6bb4) Initial plan ### 📄 Description ## Description Rejected recipients in signing certificate PDFs were visually indistinguishable from completed recipients, and their IP/Device fields displayed "Unknown" despite rejection audit logs containing this data. **Changes:** - Added red text highlighting (`#dc2626`) for rejected status in Details column - Modified `renderLabelAndText` to support custom `labelFill` and `valueFill` colors - Hide signature container for rejected recipients - Use `recipient.logs.rejected` audit log for IP Address/Device fields when recipient is rejected (falls back to `completed` otherwise) - Updated audit log generation to include completed audit logs in document sealing **Before:** Rejected status displayed in default gray color with "Unknown" IP/Device values, making rejections easy to miss. **After:** Rejected status renders in red with accurate IP Address and Device information from rejection audit log. ```typescript // IP/Device now use the appropriate audit log source const relevantLog = isRejected ? recipient.logs.rejected : recipient.logs.completed; const ipLabelAndText = renderLabelAndText({ label: i18n._(msg`IP Address`), text: relevantLog?.ipAddress ?? i18n._(msg`Unknown`), width, }); ```  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/documenso/documenso/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2335

No description provided.

Rows
Columns