[PR #2482] [MERGED] fix: envelope editor flush race condition #2334

New issue

Closed

opened 2026-02-26 20:33:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2482
Author: @dguyen
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @Mythie

Base: main ← Head: fix/envelope-editor-flush-race-condition

📝 Commits (2)

3f40d3f fix: envelope editor flush race condition
2e6d76a chore: refactor

📊 Changes

1 file changed (+23 additions, -3 deletions)

View changed files

📝 apps/remix/app/components/general/envelope-editor/envelope-editor-fields-page-renderer.tsx (+23 -3)

📄 Description

Description

Fixes a race condition in the envelope editor when opening "Send Document" immediately after moving/resizing a selected field

Replication

Move or resize a field (do not blur the selector/quickbar that appears when a field is selected)
Directly click the "Send Document" dialog
Error appears

Note: Step 2 needs to happen relatively fast after step 1 since this is a race against the flush debouncer

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2482 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/envelope-editor-flush-race-condition` --- ### 📝 Commits (2) - [`3f40d3f`](https://github.com/documenso/documenso/commit/3f40d3fe7e73775d4fa887acab574209cc8a31e3) fix: envelope editor flush race condition - [`2e6d76a`](https://github.com/documenso/documenso/commit/2e6d76af413e9b6b3ce38a3ee0f4a38c42211c76) chore: refactor ### 📊 Changes **1 file changed** (+23 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-fields-page-renderer.tsx` (+23 -3) </details> ### 📄 Description ## Description Fixes a race condition in the envelope editor when opening "Send Document" immediately after moving/resizing a selected field Replication 1. Move or resize a field (do not blur the selector/quickbar that appears when a field is selected) 2. Directly click the "Send Document" dialog 3. Error appears Note: Step 2 needs to happen relatively fast after step 1 since this is a race against the flush debouncer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2334

No description provided.

Rows
Columns