starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 14:25:59 +03:00

[PR #2479] [MERGED] fix: use rejection audit log for IP/Device fields on rejected certificates #2332

New issue

Closed

opened 2026-02-26 20:33:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2479
Author: @Copilot
Created: 2/12/2026
Status: ✅ Merged
Merged: 2/12/2026
Merged by: @dguyen

Base: fix/highlight-rejected-certificate-text ← Head: copilot/sub-pr-2478

📝 Commits (2)

26edcdb Initial plan
c35bc83 fix: use rejection log data for IP and Device fields when rejected

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 packages/lib/server-only/pdf/render-certificate.ts (+4 -2)

📄 Description

Description

When a recipient rejects a document, the certificate previously displayed "Unknown" for IP Address and Device fields because it only checked recipient.logs.completed. The rejection audit log contains this data but wasn't being used.

This addresses feedback from PR #2478: https://github.com/documenso/documenso/pull/2478#discussion_r2796368838

Test Details

This change modifies certificate rendering logic rather than adding tests. Existing E2E tests in include-document-certificate.spec.ts validate certificate generation.

Test Name: N/A
Type: N/A
Description: Bug fix, not a test addition
Inputs: N/A
Expected Output: N/A

Checklist

I have written the new test and ensured it works as intended.
I have added necessary documentation to explain the purpose of the test.
I have followed the project's testing guidelines and coding style.
I have addressed any review feedback from previous submissions, if applicable.

Additional Notes

Changes:

Modified renderColumnTwo() in render-certificate.ts to select log source based on rejection status
When isRejected is true, uses recipient.logs.rejected
Otherwise falls back to recipient.logs.completed

Before:

text: recipient.logs.completed?.ipAddress ?? i18n._(msg`Unknown`)
text: getDevice(recipient.logs.completed?.userAgent)

After:

const relevantLog = isRejected ? recipient.logs.rejected : recipient.logs.completed;

text: relevantLog?.ipAddress ?? i18n._(msg`Unknown`)
text: getDevice(relevantLog?.userAgent)

This ensures rejected certificates display accurate audit information instead of "Unknown".

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2479 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 2/12/2026 **Status:** ✅ Merged **Merged:** 2/12/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `fix/highlight-rejected-certificate-text` ← **Head:** `copilot/sub-pr-2478` --- ### 📝 Commits (2) - [`26edcdb`](https://github.com/documenso/documenso/commit/26edcdb634c33bc93e490d8be577da90761d8cab) Initial plan - [`c35bc83`](https://github.com/documenso/documenso/commit/c35bc83ffcbea98aae1273a892d40c55ac01a9ae) fix: use rejection log data for IP and Device fields when rejected ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/pdf/render-certificate.ts` (+4 -2) </details> ### 📄 Description ## Description When a recipient rejects a document, the certificate previously displayed "Unknown" for IP Address and Device fields because it only checked `recipient.logs.completed`. The rejection audit log contains this data but wasn't being used. ## Related Issue This addresses feedback from PR #2478: https://github.com/documenso/documenso/pull/2478#discussion_r2796368838 ## Test Details This change modifies certificate rendering logic rather than adding tests. Existing E2E tests in `include-document-certificate.spec.ts` validate certificate generation. - Test Name: N/A - Type: N/A - Description: Bug fix, not a test addition - Inputs: N/A - Expected Output: N/A ## Checklist - [x] I have written the new test and ensured it works as intended. - [x] I have added necessary documentation to explain the purpose of the test. - [x] I have followed the project's testing guidelines and coding style. - [x] I have addressed any review feedback from previous submissions, if applicable. ## Additional Notes **Changes:** - Modified `renderColumnTwo()` in `render-certificate.ts` to select log source based on rejection status - When `isRejected` is true, uses `recipient.logs.rejected` - Otherwise falls back to `recipient.logs.completed` **Before:** ```typescript text: recipient.logs.completed?.ipAddress ?? i18n._(msg`Unknown`) text: getDevice(recipient.logs.completed?.userAgent) ``` **After:** ```typescript const relevantLog = isRejected ? recipient.logs.rejected : recipient.logs.completed; text: relevantLog?.ipAddress ?? i18n._(msg`Unknown`) text: getDevice(relevantLog?.userAgent) ``` This ensures rejected certificates display accurate audit information instead of "Unknown".  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2332

No description provided.

Rows
Columns