[PR #2468] feat: support for external 2FA codes #2324

New issue

Open

opened 2026-02-26 20:33:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2468
Author: @ephraimduncan
Created: 2/10/2026
Status: 🔄 Open

Base: main ← Head: feat/external-2fa-codes

📝 Commits (4)

bd56929 refactor(signing-2fa): simplify server-side and UI code for external 2FA
7163800 chore: remove .sisyphus planning artifacts
9de87ca fix: move 2FA reason codes to shared constants to fix client bundle
9194884 test: remove flaky external 2fa auth test

📊 Changes

30 files changed (+1639 additions, -21 deletions)

View changed files

➕ .agents/plans/wild-cyan-rock-support-for-external-2fa-codes.md (+289 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx (+17 -10)
➕ apps/remix/app/components/general/document-signing/document-signing-auth-external-2fa.tsx (+223 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx (+9 -6)
📝 apps/remix/app/components/general/document-signing/document-signing-auto-sign.tsx (+7 -3)
📝 apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx (+1 -0)
📝 packages/lib/constants/document-auth.ts (+13 -0)
📝 packages/lib/server-only/document/complete-document-with-token.ts (+18 -2)
📝 packages/lib/server-only/document/is-recipient-authorized.ts (+17 -0)
📝 packages/lib/server-only/document/validate-field-auth.ts (+3 -0)
📝 packages/lib/server-only/field/sign-field-with-token.ts (+1 -0)
📝 packages/lib/server-only/pdf/generate-certificate-pdf.ts (+1 -0)
➕ packages/lib/server-only/signing-2fa/get-signing-two-factor-status.ts (+105 -0)
➕ packages/lib/server-only/signing-2fa/issue-signing-two-factor-token.ts (+176 -0)
➕ packages/lib/server-only/signing-2fa/token-utils.ts (+30 -0)
➕ packages/lib/server-only/signing-2fa/verify-signing-two-factor-token.ts (+245 -0)
📝 packages/lib/types/document-audit-logs.ts (+67 -0)
📝 packages/lib/types/document-auth.ts (+10 -0)
📝 packages/lib/types/subscription.ts (+7 -0)
📝 packages/lib/utils/document-audit-logs.ts (+42 -0)

...and 10 more files

📄 Description

Demo

https://github.com/user-attachments/assets/56041bc9-7745-4ab7-b00e-49062e3db2e9

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2468 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 2/10/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/external-2fa-codes` --- ### 📝 Commits (4) - [`bd56929`](https://github.com/documenso/documenso/commit/bd56929db117e8e9ae77f1fe05f34818e55b8622) refactor(signing-2fa): simplify server-side and UI code for external 2FA - [`7163800`](https://github.com/documenso/documenso/commit/7163800d3649532ad96598ddbd54c649c3bc24eb) chore: remove .sisyphus planning artifacts - [`9de87ca`](https://github.com/documenso/documenso/commit/9de87ca9063ff4fb341200d4ead25bdf8d11f9cb) fix: move 2FA reason codes to shared constants to fix client bundle - [`9194884`](https://github.com/documenso/documenso/commit/9194884fbe30ab352ce0828577e8c67cf97c58c5) test: remove flaky external 2fa auth test ### 📊 Changes **30 files changed** (+1639 additions, -21 deletions) <details> <summary>View changed files</summary> ➕ `.agents/plans/wild-cyan-rock-support-for-external-2fa-codes.md` (+289 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx` (+17 -10) ➕ `apps/remix/app/components/general/document-signing/document-signing-auth-external-2fa.tsx` (+223 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx` (+9 -6) 📝 `apps/remix/app/components/general/document-signing/document-signing-auto-sign.tsx` (+7 -3) 📝 `apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx` (+1 -0) 📝 `packages/lib/constants/document-auth.ts` (+13 -0) 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+18 -2) 📝 `packages/lib/server-only/document/is-recipient-authorized.ts` (+17 -0) 📝 `packages/lib/server-only/document/validate-field-auth.ts` (+3 -0) 📝 `packages/lib/server-only/field/sign-field-with-token.ts` (+1 -0) 📝 `packages/lib/server-only/pdf/generate-certificate-pdf.ts` (+1 -0) ➕ `packages/lib/server-only/signing-2fa/get-signing-two-factor-status.ts` (+105 -0) ➕ `packages/lib/server-only/signing-2fa/issue-signing-two-factor-token.ts` (+176 -0) ➕ `packages/lib/server-only/signing-2fa/token-utils.ts` (+30 -0) ➕ `packages/lib/server-only/signing-2fa/verify-signing-two-factor-token.ts` (+245 -0) 📝 `packages/lib/types/document-audit-logs.ts` (+67 -0) 📝 `packages/lib/types/document-auth.ts` (+10 -0) 📝 `packages/lib/types/subscription.ts` (+7 -0) 📝 `packages/lib/utils/document-audit-logs.ts` (+42 -0) _...and 10 more files_ </details> ### 📄 Description ## Demo https://github.com/user-attachments/assets/56041bc9-7745-4ab7-b00e-49062e3db2e9 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:33:23 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2324

No description provided.

Rows
Columns