starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2463] [CLOSED] fix: embedded links in PDF not clickable when signing (#2370) #2323

New issue

Closed

opened 2026-02-26 20:33:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2463
Author: @Jahangirbabar2000
Created: 2/9/2026
Status: ❌ Closed

Base: main ← Head: fix/pdf-embedded-links-clickable-2370

📝 Commits (3)

08f2f30 fix: make embedded links in PDF clickable during document signing (#2370)
59079dc Merge branch 'main' into fix/pdf-embedded-links-clickable-2370
3846ad8 Merge branch 'main' into fix/pdf-embedded-links-clickable-2370

📊 Changes

3 files changed (+24 additions, -2 deletions)

View changed files

📝 apps/remix/app/app.css (+22 -0)
📝 packages/ui/components/pdf-viewer/pdf-viewer-konva.tsx (+1 -1)
📝 packages/ui/primitives/pdf-viewer/base.tsx (+1 -1)

📄 Description

Description

Enables embedded PDF links to be clickable during document signing. Previously, links were not interactive because the PDF annotation layer was disabled. This change enables the annotation layer and ensures it renders above the Konva signing overlay without interfering with signing field interactions.

Fixes #2370

Changes Made

Enabled renderAnnotationLayer={true} in pdf-viewer-konva.tsx (used for signing/editing flows)
Enabled renderAnnotationLayer={true} in base.tsx (base PDF viewer component)
Imported react-pdf/dist/Page/AnnotationLayer.css in app.css for proper annotation layer styling
Added CSS overrides to ensure annotation layer renders above Konva overlay (z-index: 20) and only link annotations capture pointer events (other annotations are disabled to avoid interfering with signing field interactions)

Testing Performed

Verified that embedded PDF links are now clickable in the signing view
Confirmed that links open in a new tab (via externalLinkTarget="_blank" prop)
Verified that signing field interactions (clicking signature fields, text fields, etc.) still work correctly
Confirmed no linter errors introduced
Tested that the annotation layer properly overlays the PDF content without visual artifacts

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

The annotation layer is positioned with z-index: 20 to sit above the Konva overlay (z-index: 10) used for signing fields
Pointer events are selectively enabled only on .linkAnnotation elements to prevent other PDF annotations (form fields, etc.) from interfering with Documenso's custom signing field interactions
The text layer remains disabled (renderTextLayer={false}) as it's not needed for this fix
This change affects both the signing flow (pdf-viewer-konva.tsx) and the base viewer (base.tsx), ensuring consistency across all PDF viewing contexts

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2463 **Author:** [@Jahangirbabar2000](https://github.com/Jahangirbabar2000) **Created:** 2/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pdf-embedded-links-clickable-2370` --- ### 📝 Commits (3) - [`08f2f30`](https://github.com/documenso/documenso/commit/08f2f3064218b69b3d4b699fc3297d6564642370) fix: make embedded links in PDF clickable during document signing (#2370) - [`59079dc`](https://github.com/documenso/documenso/commit/59079dc4043efdf576e07091772fa26d262d9624) Merge branch 'main' into fix/pdf-embedded-links-clickable-2370 - [`3846ad8`](https://github.com/documenso/documenso/commit/3846ad86e7b77ee3f0a2a5f04503689db62ef83d) Merge branch 'main' into fix/pdf-embedded-links-clickable-2370 ### 📊 Changes **3 files changed** (+24 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/app.css` (+22 -0) 📝 `packages/ui/components/pdf-viewer/pdf-viewer-konva.tsx` (+1 -1) 📝 `packages/ui/primitives/pdf-viewer/base.tsx` (+1 -1) </details> ### 📄 Description ## Description Enables embedded PDF links to be clickable during document signing. Previously, links were not interactive because the PDF annotation layer was disabled. This change enables the annotation layer and ensures it renders above the Konva signing overlay without interfering with signing field interactions. ## Related Issue Fixes #[2370](https://github.com/documenso/documenso/issues/2370) ## Changes Made 1. Enabled renderAnnotationLayer={true} in pdf-viewer-konva.tsx (used for signing/editing flows) 2. Enabled renderAnnotationLayer={true} in base.tsx (base PDF viewer component) 3. Imported react-pdf/dist/Page/AnnotationLayer.css in app.css for proper annotation layer styling 4. Added CSS overrides to ensure annotation layer renders above Konva overlay (z-index: 20) and only link annotations capture pointer events (other annotations are disabled to avoid interfering with signing field interactions) ## Testing Performed 1. Verified that embedded PDF links are now clickable in the signing view 2. Confirmed that links open in a new tab (via externalLinkTarget="_blank" prop) 3. Verified that signing field interactions (clicking signature fields, text fields, etc.) still work correctly 4. Confirmed no linter errors introduced 5. Tested that the annotation layer properly overlays the PDF content without visual artifacts ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   1. The annotation layer is positioned with z-index: 20 to sit above the Konva overlay (z-index: 10) used for signing fields 2. Pointer events are selectively enabled only on .linkAnnotation elements to prevent other PDF annotations (form fields, etc.) from interfering with Documenso's custom signing field interactions 3. The text layer remains disabled (renderTextLayer={false}) as it's not needed for this fix 4. This change affects both the signing flow (pdf-viewer-konva.tsx) and the base viewer (base.tsx), ensuring consistency across all PDF viewing contexts --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:23 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2323

No description provided.

Rows
Columns