[PR #2451] [MERGED] fix(i18n): create full sentences for document-signing-auth files #2314

New issue

Closed

opened 2026-02-26 20:33:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2451
Author: @McMek590
Created: 2/6/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @dguyen

Base: main ← Head: document-signing-auth

📝 Commits (2)

b32df01 fix(i18n): create full sentences for document-signing-auth files
1ef565a refactor: create full sentences for document-signing-auth file

📊 Changes

4 files changed (+241 additions, -56 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx (+36 -10)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-account.tsx (+105 -28)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-passkey.tsx (+100 -14)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-password.tsx (+0 -4)

📄 Description

Description

Hi all! There are many problems when the translator needs to adjust a variable to full sentence. Most languages are not as easy as English, so you can't create a "Lego sentence".

I prepared full sentence for 4 document-signing-auth files because I don't have any better idea how to solve this localization issue. I'm waiting for any feedback :)

Changes Made

Removed "Lego sentences" and added full sentence easy to translate.

Testing Performed

Check build

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2451 **Author:** [@McMek590](https://github.com/McMek590) **Created:** 2/6/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `document-signing-auth` --- ### 📝 Commits (2) - [`b32df01`](https://github.com/documenso/documenso/commit/b32df017d25f9229ef6d7a8cf4d745dbe2c62531) fix(i18n): create full sentences for document-signing-auth files - [`1ef565a`](https://github.com/documenso/documenso/commit/1ef565a4b068fdc86716f69f0ac0698517b73e25) refactor: create full sentences for document-signing-auth file ### 📊 Changes **4 files changed** (+241 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx` (+36 -10) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-account.tsx` (+105 -28) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-passkey.tsx` (+100 -14) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-password.tsx` (+0 -4) </details> ### 📄 Description ## Description Hi all! There are many problems when the translator needs to adjust a variable to full sentence. Most languages are not as easy as English, so you can't create a "Lego sentence". I prepared full sentence for 4 document-signing-auth files because I don't have any better idea how to solve this localization issue. I'm waiting for any feedback :) ## Changes Made - Removed "Lego sentences" and added full sentence easy to translate. ## Testing Performed - Check build ## Checklist   - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2314

No description provided.

Rows
Columns