[PR #2448] [MERGED] fix(ui): clarify email settings labels #2312

New issue

Closed

opened 2026-02-26 20:33:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2448
Author: @LouisLau-art
Created: 2/5/2026
Status: ✅ Merged
Merged: 2/16/2026
Merged by: @dguyen

Base: main ← Head: fix/email-settings-copy

📝 Commits (3)

6c70222 fix(ui): clarify email settings labels
a0b43e8 Merge branch 'main' into fix/email-settings-copy
3e139b6 fix(ui): keep email label updates in source strings

📊 Changes

3 files changed (+49 additions, -35 deletions)

View changed files

📝 packages/app-tests/e2e/document-flow/autosave-subject-step.spec.ts (+30 -22)
📝 packages/app-tests/e2e/organisations/organisation-team-preferences.spec.ts (+12 -6)
📝 packages/ui/components/document/document-email-checkboxes.tsx (+7 -7)

📄 Description

Fixes documenso/documenso#2341.

What changed

Reworded the English labels for the document email settings checkboxes to be explicit about who receives the email and when.
Reordered the checkboxes to group owner notifications first, then recipient notifications.
Updated the E2E tests that reference these checkbox labels.

Notes

To avoid churning translation keys, this keeps the existing Lingui msgids and updates the English msgstrs in packages/lib/translations/en/web.po.
Tooltips were left as-is (they still provide the full detail).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2448 **Author:** [@LouisLau-art](https://github.com/LouisLau-art) **Created:** 2/5/2026 **Status:** ✅ Merged **Merged:** 2/16/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/email-settings-copy` --- ### 📝 Commits (3) - [`6c70222`](https://github.com/documenso/documenso/commit/6c702226ccf3285cc9303a5c0ad6686432fbc5d2) fix(ui): clarify email settings labels - [`a0b43e8`](https://github.com/documenso/documenso/commit/a0b43e86e8745588e2ee76af06477fca4bb62a73) Merge branch 'main' into fix/email-settings-copy - [`3e139b6`](https://github.com/documenso/documenso/commit/3e139b667dc83768018b8580c8ccf18ef415499e) fix(ui): keep email label updates in source strings ### 📊 Changes **3 files changed** (+49 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `packages/app-tests/e2e/document-flow/autosave-subject-step.spec.ts` (+30 -22) 📝 `packages/app-tests/e2e/organisations/organisation-team-preferences.spec.ts` (+12 -6) 📝 `packages/ui/components/document/document-email-checkboxes.tsx` (+7 -7) </details> ### 📄 Description Fixes documenso/documenso#2341. What changed - Reworded the **English** labels for the document email settings checkboxes to be explicit about *who* receives the email and *when*. - Reordered the checkboxes to group owner notifications first, then recipient notifications. - Updated the E2E tests that reference these checkbox labels. Notes - To avoid churning translation keys, this keeps the existing Lingui `msgid`s and updates the English `msgstr`s in `packages/lib/translations/en/web.po`. - Tooltips were left as-is (they still provide the full detail). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2312

No description provided.

Rows
Columns