[PR #2436] [CLOSED] fix: checkbox states not showing in signed PDF for legacy uploads #2304

New issue

Closed

opened 2026-02-26 20:33:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2436
Author: @catalinpit
Created: 1/30/2026
Status: ❌ Closed

Base: main ← Head: fix/checkbox-checked-values

📝 Commits (1)

aed55e9 fix: checkbox states not showing in signed PDF for legacy uploads

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 packages/lib/jobs/definitions/internal/seal-document.handler.ts (+5 -0)

📄 Description

Flatten the pdf-lib form before saving to bake checkbox/radio appearances into the PDF content. This ensures checked states are preserved when the PDF is subsequently processed by libpdf for final signing.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2436 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 1/30/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/checkbox-checked-values` --- ### 📝 Commits (1) - [`aed55e9`](https://github.com/documenso/documenso/commit/aed55e9bcd3cf15c07f1328a79af69b22d75c3da) fix: checkbox states not showing in signed PDF for legacy uploads ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/jobs/definitions/internal/seal-document.handler.ts` (+5 -0) </details> ### 📄 Description Flatten the pdf-lib form before saving to bake checkbox/radio appearances into the PDF content. This ensures checked states are preserved when the PDF is subsequently processed by libpdf for final signing. ## Checklist   - [ ] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:18 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2304

No description provided.

Rows
Columns