[PR #2421] [MERGED] fix: preserve prompt parameter in OAuth authorize URL builder #2293

New issue

Closed

opened 2026-02-26 20:33:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2421
Author: @Mythie
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @Mythie

Base: main ← Head: fix/oauth-authorize-url-prompt

📝 Commits (1)

e4e3c1b fix: preserve prompt parameter in OAuth authorize URL builder

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 packages/auth/server/lib/utils/handle-oauth-authorize-url.ts (+10 -4)

📄 Description

The prompt option was being discarded for OAuth authorize URLs after
adding support for the NEXT_PRIVATE_OIDC_PROMPT env var. This meant
select_account (used elsewhere) was not being passed through.

Now defaults prompt to the provided option (or 'login'), and only
overwrites it when a valid OIDC prompt env var is set. Also adds a
type guard to validate the env var value.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2421 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/oauth-authorize-url-prompt` --- ### 📝 Commits (1) - [`e4e3c1b`](https://github.com/documenso/documenso/commit/e4e3c1b5cae0723c8d73f1eaa1b326560008c8de) fix: preserve prompt parameter in OAuth authorize URL builder ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/auth/server/lib/utils/handle-oauth-authorize-url.ts` (+10 -4) </details> ### 📄 Description The prompt option was being discarded for OAuth authorize URLs after adding support for the NEXT_PRIVATE_OIDC_PROMPT env var. This meant select_account (used elsewhere) was not being passed through. Now defaults prompt to the provided option (or 'login'), and only overwrites it when a valid OIDC prompt env var is set. Also adds a type guard to validate the env var value. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:15 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2293

No description provided.

Rows
Columns