[GH-ISSUE #768] The download of the signed file doesn't work when S3 is enabled #228

Closed
opened 2026-02-26 18:46:00 +03:00 by kerem · 10 comments
Owner

Originally created by @myugan on GitHub (Dec 18, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/768

Issue Description

I'm using version v1.2.3 and it appears that using an S3 bucket as file storage is causing some issues. I've noticed that even after the signing is completed, I'm unable to download the file despite having full S3 access to the specified bucket through IAM configuration.

Steps to Reproduce

Just by following the steps on how to upload a document and add a signer, after the signer gives a signature, we receive a notification to download the file. Alternatively, the page will display a download button after the signature is completed.

Expected Behavior

Download button should be working fine

Current Behavior

Not able to download signed document.

Screenshots (optional)

image image

Operating System [e.g., Windows 10]

No response

Browser [e.g., Chrome, Firefox]

Firefox

Version [e.g., 2.0.1]

v1.2.3

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
Originally created by @myugan on GitHub (Dec 18, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/768 ### Issue Description I'm using version v1.2.3 and it appears that using an S3 bucket as file storage is causing some issues. I've noticed that even after the signing is completed, I'm unable to download the file despite having full S3 access to the specified bucket through IAM configuration. ### Steps to Reproduce Just by following the steps on how to upload a document and add a signer, after the signer gives a signature, we receive a notification to download the file. Alternatively, the page will display a download button after the signature is completed. ### Expected Behavior Download button should be working fine ### Current Behavior Not able to download signed document. ### Screenshots (optional) <img width="2056" alt="image" src="https://github.com/documenso/documenso/assets/20453528/331219b4-b260-4211-b347-2ea0afd6556a"> <img width="425" alt="image" src="https://github.com/documenso/documenso/assets/20453528/30c810bb-e266-40f7-a4b4-227ef8f3153e"> ### Operating System [e.g., Windows 10] _No response_ ### Browser [e.g., Chrome, Firefox] Firefox ### Version [e.g., 2.0.1] v1.2.3 ### Please check the boxes that apply to this issue report. - [x] I have searched the existing issues to make sure this is not a duplicate. - [x] I have provided steps to reproduce the issue. - [x] I have included relevant environment information. - [x] I have included any relevant screenshots. - [ ] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [ ] I want to work on creating a PR for this issue if approved
Author
Owner

@catalinpit commented on GitHub (Dec 19, 2023):

Thanks for signalling this issue @myugan!

<!-- gh-comment-id:1862387007 --> @catalinpit commented on GitHub (Dec 19, 2023): Thanks for signalling this issue @myugan!
Author
Owner

@VishalMCF commented on GitHub (Dec 20, 2023):

Hello Do I need to setup any S3 bucket using localstack or the docker containers -> inbucket/minio will be sufficient to debug this issue? I feel it should be sufficient as what mentioned in the docker-compose file (about minio) is what matches with the .env.example file

<!-- gh-comment-id:1864390557 --> @VishalMCF commented on GitHub (Dec 20, 2023): Hello Do I need to setup any S3 bucket using localstack or the docker containers -> inbucket/minio will be sufficient to debug this issue? I feel it should be sufficient as what mentioned in the docker-compose file (about minio) is what matches with the .env.example file
Author
Owner

@catalinpit commented on GitHub (Dec 20, 2023):

Hello Do I need to setup any S3 bucket using localstack or the docker containers -> inbucket/minio will be sufficient to debug this issue? I feel it should be sufficient as what mentioned in the docker-compose file (about minio) is what matches with the .env.example file

Minio should be fine. That's what I use as well.

<!-- gh-comment-id:1864397379 --> @catalinpit commented on GitHub (Dec 20, 2023): > Hello Do I need to setup any S3 bucket using localstack or the docker containers -> inbucket/minio will be sufficient to debug this issue? I feel it should be sufficient as what mentioned in the docker-compose file (about minio) is what matches with the .env.example file Minio should be fine. That's what I use as well.
Author
Owner

@myugan commented on GitHub (Dec 20, 2023):

I prefer using an S3 bucket because it doesn't require maintenance and its storage capacity isn't dependent on the operating system. I've noticed the new addition of MinIO for storage, but personally, I would rather not use it

<!-- gh-comment-id:1864452957 --> @myugan commented on GitHub (Dec 20, 2023): I prefer using an S3 bucket because it doesn't require maintenance and its storage capacity isn't dependent on the operating system. I've noticed the new addition of MinIO for storage, but personally, I would rather not use it
Author
Owner

@VishalMCF commented on GitHub (Dec 20, 2023):

@myugan @catalinpit I cloned the project yesterday and I did all the steps. In my case I am able to download the file after successful siging in. Think it is a version issue only. Do we have to update that version ? If yes then I am not sure how I can edit that version source code.

<!-- gh-comment-id:1864455962 --> @VishalMCF commented on GitHub (Dec 20, 2023): @myugan @catalinpit I cloned the project yesterday and I did all the steps. In my case I am able to download the file after successful siging in. Think it is a version issue only. Do we have to update that version ? If yes then I am not sure how I can edit that version source code.
Author
Owner

@Aj7Ay commented on GitHub (Dec 20, 2023):

@VishalMCF Are you currently able to download files successfully using S3? Additionally, we are using version 1.3.0 and encountering an error.

<!-- gh-comment-id:1864481476 --> @Aj7Ay commented on GitHub (Dec 20, 2023): @VishalMCF Are you currently able to download files successfully using S3? Additionally, we are using version 1.3.0 and encountering an error.
Author
Owner

@VishalMCF commented on GitHub (Dec 20, 2023):

Hello @Aj7Ay I will tell you what I did when I ran locally:-

  1. NEXT_PUBLIC_UPLOAD_TRANSPORT="s3"
    Logged in using OAuth and assigned myself a file to sign.
    After signing the file I got this page:-

https://github.com/documenso/documenso/assets/70262922/f2b494f2-4c9a-4110-8b84-89dadbca3c0b

Then when i click on download button it shows file downloaded.
Was i on the right track or I missed something?

<!-- gh-comment-id:1864498318 --> @VishalMCF commented on GitHub (Dec 20, 2023): Hello @Aj7Ay I will tell you what I did when I ran locally:- 1. NEXT_PUBLIC_UPLOAD_TRANSPORT="s3" Logged in using OAuth and assigned myself a file to sign. After signing the file I got this page:- https://github.com/documenso/documenso/assets/70262922/f2b494f2-4c9a-4110-8b84-89dadbca3c0b Then when i click on download button it shows file downloaded. Was i on the right track or I missed something?
Author
Owner

@catalinpit commented on GitHub (Jan 8, 2024):

@myugan @catalinpit I cloned the project yesterday and I did all the steps. In my case I am able to download the file after successful siging in. Think it is a version issue only. Do we have to update that version ? If yes then I am not sure how I can edit that version source code.

Can't reproduce the error either. At least using minIO. I'll try using S3 directly and see.

@Aj7Ay it would be helpful if you could share a screen with the error you're getting (browser console or server logs). Thanks!

<!-- gh-comment-id:1881066971 --> @catalinpit commented on GitHub (Jan 8, 2024): > @myugan @catalinpit I cloned the project yesterday and I did all the steps. In my case I am able to download the file after successful siging in. Think it is a version issue only. Do we have to update that version ? If yes then I am not sure how I can edit that version source code. Can't reproduce the error either. At least using minIO. I'll try using S3 directly and see. @Aj7Ay it would be helpful if you could share a screen with the error you're getting (browser console or server logs). Thanks!
Author
Owner

@catalinpit commented on GitHub (Jan 9, 2024):

Ok, I tried using AWS directly and still can't reproduce the issue. Can anyone reproduce it or did anyone reproduce it recently?

<!-- gh-comment-id:1882684797 --> @catalinpit commented on GitHub (Jan 9, 2024): Ok, I tried using AWS directly and still can't reproduce the issue. Can anyone reproduce it or did anyone reproduce it recently?
Author
Owner

@catalinpit commented on GitHub (Jan 12, 2024):

I'll close this since there is no activity. If anybody runs into this issue again, please open a new issue and we'll investigate it.

<!-- gh-comment-id:1888690637 --> @catalinpit commented on GitHub (Jan 12, 2024): I'll close this since there is no activity. If anybody runs into this issue again, please open a new issue and we'll investigate it.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#228
No description provided.