[PR #2386] [MERGED] fix: dont flatten forms for templates #2266

New issue

Closed

opened 2026-02-26 20:33:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2386
Author: @Mythie
Created: 1/13/2026
Status: ✅ Merged
Merged: 1/14/2026
Merged by: @Mythie

Base: main ← Head: fix/dont-flatten-template-forms

📝 Commits (4)

44887c5 fix: dont flatten forms for templates
b4b4010 fix: standardise flattening
c17806f chore: add tests
83303ff fix: update tests

📊 Changes

14 files changed (+918 additions, -71 deletions)

View changed files

➕ assets/form-fields-test.pdf (+0 -0)
📝 packages/api/v1/implementation.ts (+3 -51)
➕ packages/app-tests/e2e/scenarios/form-flattening.spec.ts (+848 -0)
📝 packages/app-tests/e2e/templates/create-document-from-template.spec.ts (+3 -1)
📝 packages/lib/server-only/document/send-document.ts (+2 -2)
📝 packages/lib/server-only/envelope/create-envelope.ts (+3 -1)
📝 packages/lib/server-only/pdf/normalize-pdf.ts (+8 -3)
📝 packages/lib/server-only/template/create-document-from-template.ts (+17 -4)
📝 packages/lib/universal/upload/put-file.server.ts (+5 -2)
📝 packages/trpc/server/envelope-router/create-envelope.ts (+12 -5)
📝 packages/trpc/server/envelope-router/use-envelope.ts (+6 -1)
📝 packages/trpc/server/envelope-router/use-envelope.types.ts (+3 -0)
📝 packages/trpc/server/template-router/router.ts (+5 -1)
📝 packages/trpc/server/template-router/schema.ts (+3 -0)

📄 Description

Templates shouldn't have their form flattened until they're
converted to a document.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2386 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 1/13/2026 **Status:** ✅ Merged **Merged:** 1/14/2026 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/dont-flatten-template-forms` --- ### 📝 Commits (4) - [`44887c5`](https://github.com/documenso/documenso/commit/44887c5486bcf4e59eb5ca4679ada5c862a9386c) fix: dont flatten forms for templates - [`b4b4010`](https://github.com/documenso/documenso/commit/b4b4010f586d7c9ad14282bf3b50d7376ecb0332) fix: standardise flattening - [`c17806f`](https://github.com/documenso/documenso/commit/c17806f2c23d2dc0111760ced9fc224098b1b768) chore: add tests - [`83303ff`](https://github.com/documenso/documenso/commit/83303ff2c3d54b8688ca695d03ed0d23bc2aff15) fix: update tests ### 📊 Changes **14 files changed** (+918 additions, -71 deletions) <details> <summary>View changed files</summary> ➕ `assets/form-fields-test.pdf` (+0 -0) 📝 `packages/api/v1/implementation.ts` (+3 -51) ➕ `packages/app-tests/e2e/scenarios/form-flattening.spec.ts` (+848 -0) 📝 `packages/app-tests/e2e/templates/create-document-from-template.spec.ts` (+3 -1) 📝 `packages/lib/server-only/document/send-document.ts` (+2 -2) 📝 `packages/lib/server-only/envelope/create-envelope.ts` (+3 -1) 📝 `packages/lib/server-only/pdf/normalize-pdf.ts` (+8 -3) 📝 `packages/lib/server-only/template/create-document-from-template.ts` (+17 -4) 📝 `packages/lib/universal/upload/put-file.server.ts` (+5 -2) 📝 `packages/trpc/server/envelope-router/create-envelope.ts` (+12 -5) 📝 `packages/trpc/server/envelope-router/use-envelope.ts` (+6 -1) 📝 `packages/trpc/server/envelope-router/use-envelope.types.ts` (+3 -0) 📝 `packages/trpc/server/template-router/router.ts` (+5 -1) 📝 `packages/trpc/server/template-router/schema.ts` (+3 -0) </details> ### 📄 Description Templates shouldn't have their form flattened until they're converted to a document. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2266

No description provided.

Rows
Columns