starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #2369] [MERGED] refactor: simplify field dialog component #2254

New issue

Closed

opened 2026-02-26 20:33:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:33:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2369
Author: @catalinpit
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/13/2026
Merged by: @Mythie

Base: main ← Head: fix/fields-dialog-text

📝 Commits (3)

44d9792 refactor: simplify field dialog component
3ee8e7f refactor: unify dialog title and improve button clarity
dcde52f refactor: update dialog titles and descriptions for clarity

📊 Changes

6 files changed (+20 additions, -32 deletions)

View changed files

📝 apps/remix/app/components/dialogs/sign-field-checkbox-dialog.tsx (+4 -6)
📝 apps/remix/app/components/dialogs/sign-field-email-dialog.tsx (+3 -3)
📝 apps/remix/app/components/dialogs/sign-field-initials-dialog.tsx (+3 -3)
📝 apps/remix/app/components/dialogs/sign-field-name-dialog.tsx (+3 -3)
📝 apps/remix/app/components/dialogs/sign-field-number-dialog.tsx (+3 -8)
📝 apps/remix/app/components/dialogs/sign-field-text-dialog.tsx (+4 -9)

📄 Description

Description

The text and number field dialogs used "Sign" terminology, which was confusing because users aren't signing. They're entering text (e.g., phone numbers, addresses). The dialog title and submit button both used "Sign", and the description was redundant.

Updated the dialog to use clearer, contextual wording:

Use the field label in the dialog title when available (e.g., "Phone Number" instead of "Sign Text Field")
Remove the redundant description altogether
Change the submit button from "Sign" to "Enter"
Remove duplicate form label (now shown only in the dialog title)

Before

Text

Email

Initials

Name

Checkbox

After

Text

Text with label

Initials

Name

Email

Checkboxes

Number

Number with label

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2369 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/fields-dialog-text` --- ### 📝 Commits (3) - [`44d9792`](https://github.com/documenso/documenso/commit/44d979225669a28722448e3a7e568a27cf25a994) refactor: simplify field dialog component - [`3ee8e7f`](https://github.com/documenso/documenso/commit/3ee8e7fcef3b1187532f0af990e555af765df96a) refactor: unify dialog title and improve button clarity - [`dcde52f`](https://github.com/documenso/documenso/commit/dcde52f4f825600eaa6fd3ec18f42801b0e62bcd) refactor: update dialog titles and descriptions for clarity ### 📊 Changes **6 files changed** (+20 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/sign-field-checkbox-dialog.tsx` (+4 -6) 📝 `apps/remix/app/components/dialogs/sign-field-email-dialog.tsx` (+3 -3) 📝 `apps/remix/app/components/dialogs/sign-field-initials-dialog.tsx` (+3 -3) 📝 `apps/remix/app/components/dialogs/sign-field-name-dialog.tsx` (+3 -3) 📝 `apps/remix/app/components/dialogs/sign-field-number-dialog.tsx` (+3 -8) 📝 `apps/remix/app/components/dialogs/sign-field-text-dialog.tsx` (+4 -9) </details> ### 📄 Description ## Description The text and number field dialogs used "Sign" terminology, which was confusing because users aren't signing. They're entering text (e.g., phone numbers, addresses). The dialog title and submit button both used "Sign", and the description was redundant. Updated the dialog to use clearer, contextual wording: - Use the field label in the dialog title when available (e.g., "Phone Number" instead of "Sign Text Field") - Remove the redundant description altogether - Change the submit button from "Sign" to "Enter" - Remove duplicate form label (now shown only in the dialog title) <details> <summary>Before</summary> ## Text <img width="545" height="322" alt="Screenshot 2026-01-08 at 13 19 08" src="https://github.com/user-attachments/assets/d42fa636-5c96-465c-b03c-61d46b01f944" /> ## Email <img width="523" height="232" alt="email-old" src="https://github.com/user-attachments/assets/47e9eb67-4eca-43e9-a379-52a8412164eb" /> ## Initials <img width="523" height="232" alt="initials-old" src="https://github.com/user-attachments/assets/de66251f-dadd-4de9-b491-a0089cea58df" /> ## Name <img width="523" height="232" alt="name-old" src="https://github.com/user-attachments/assets/5d96fad2-5937-43f6-a76a-b242c7572009" /> ## Checkbox <img width="523" height="306" alt="checkbox-old" src="https://github.com/user-attachments/assets/e48ae92e-dd13-4974-bd5d-5cb0a6549790" /> </details> <details> <summary>After</summary> ## Text <img width="523" height="273" alt="text-updated" src="https://github.com/user-attachments/assets/3419b984-5706-4fad-98b9-cb9f9ec93d5b" /> ## Text with label <img width="521" height="269" alt="Screenshot 2026-01-09 at 16 16 24" src="https://github.com/user-attachments/assets/35837ef4-2baf-4dac-a881-51e034ffe740" /> ## Initials <img width="523" height="264" alt="initials-updated" src="https://github.com/user-attachments/assets/62a1a214-50e3-457d-b6bf-d1b35037d6e6" /> ## Name <img width="523" height="232" alt="name-updated" src="https://github.com/user-attachments/assets/effe3eb3-a477-49a7-87f4-fb580695149c" /> ## Email <img width="523" height="232" alt="email-updated" src="https://github.com/user-attachments/assets/6afd677f-d9f8-4769-9259-0f348e982607" /> ## Checkboxes <img width="523" height="306" alt="checkbox-updated" src="https://github.com/user-attachments/assets/913b2d78-daba-407c-8e43-a1fcdcfa5f20" /> ## Number <img width="523" height="232" alt="number-updated" src="https://github.com/user-attachments/assets/df70432d-ae20-49a2-a7ff-e1e4eb38102e" /> ## Number with label <img width="521" height="231" alt="Screenshot 2026-01-09 at 16 16 39" src="https://github.com/user-attachments/assets/be7b5b21-bbc1-49a9-a396-4bce5ac5ffdd" /> </details> ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:33:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2254

No description provided.

Rows
Columns