[PR #2364] feat: support language in embedding #2248

Open
opened 2026-02-26 20:33:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2364
Author: @tedliang
Created: 1/6/2026
Status: 🔄 Open

Base: mainHead: feature/support-languange-in-embedding


📝 Commits (1)

  • 4c60760 feat: support language in embedding

📊 Changes

10 files changed (+25 additions, -1 deletions)

View changed files

📝 apps/documentation/pages/developers/embedding/authoring.mdx (+1 -0)
📝 apps/documentation/pages/developers/embedding/preact.mdx (+1 -0)
📝 apps/documentation/pages/developers/embedding/react.mdx (+1 -0)
📝 apps/documentation/pages/developers/embedding/solid.mdx (+1 -0)
📝 apps/documentation/pages/developers/embedding/svelte.mdx (+1 -0)
📝 apps/documentation/pages/developers/embedding/vue.mdx (+1 -0)
📝 apps/remix/app/components/embed/embed-document-signing-page-v2.tsx (+6 -0)
📝 apps/remix/app/routes/embed+/v1+/authoring+/_layout.tsx (+7 -1)
📝 apps/remix/app/types/embed-base-schemas.ts (+3 -0)
📝 apps/remix/app/types/embed-document-sign-schema.ts (+3 -0)

📄 Description

Description

Support language in embedding

N/A

Changes Made

  • Introduce optional configuration language in embed authoring and signing

Testing Performed

  • Tested on Chrome

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2364 **Author:** [@tedliang](https://github.com/tedliang) **Created:** 1/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature/support-languange-in-embedding` --- ### 📝 Commits (1) - [`4c60760`](https://github.com/documenso/documenso/commit/4c607608b784ac8476c00a96da31a5ca11d4d07f) feat: support language in embedding ### 📊 Changes **10 files changed** (+25 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/documentation/pages/developers/embedding/authoring.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/embedding/preact.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/embedding/react.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/embedding/solid.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/embedding/svelte.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/embedding/vue.mdx` (+1 -0) 📝 `apps/remix/app/components/embed/embed-document-signing-page-v2.tsx` (+6 -0) 📝 `apps/remix/app/routes/embed+/v1+/authoring+/_layout.tsx` (+7 -1) 📝 `apps/remix/app/types/embed-base-schemas.ts` (+3 -0) 📝 `apps/remix/app/types/embed-document-sign-schema.ts` (+3 -0) </details> ### 📄 Description ## Description Support language in embedding ## Related Issue N/A ## Changes Made <!--- Provide a summary of the changes made in this pull request. --> <!--- Include any relevant technical details or architecture changes. --> - Introduce optional configuration `language` in embed authoring and signing ## Testing Performed <!--- Describe the testing that you have performed to validate these changes. --> <!--- Include information about test cases, testing environments, and results. --> - Tested on Chrome ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [X] I have tested these changes locally and they work as expected. - [X] I have added/updated tests that prove the effectiveness of these changes. - [X] I have updated the documentation to reflect these changes, if applicable. - [X] I have followed the project's coding style guidelines. - [X] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <!--- Provide any additional context or notes for the reviewers. --> <!--- This might include details about design decisions, potential concerns, or anything else relevant. --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2248
No description provided.