starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2330] [MERGED] fix: mark document visibility options for translation #2220

New issue

Closed

opened 2026-02-26 20:32:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2330
Author: @mKoonrad
Created: 12/16/2025
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @dguyen

Base: main ← Head: document-visibility

📝 Commits (3)

459cd5d fix(i18n): mark document visibility options for translation
b8df918 fix(i18n): mark dialogTitle for translation
38069e1 Merge branch 'main' into document-visibility

📊 Changes

3 files changed (+17 additions, -10 deletions)

View changed files

📝 apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx (+3 -1)
📝 packages/lib/constants/document-visibility.ts (+7 -4)
📝 packages/ui/components/document/document-visibility-select.tsx (+7 -5)

📄 Description

Description

I marked document visibility options for translation.

Before:

After:

Changes Made

Mark document visibility options for translation
Mark Document Settings header strings with <Trans> tag

Testing Performed

npm run build
Check local run
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2330 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 12/16/2025 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `document-visibility` --- ### 📝 Commits (3) - [`459cd5d`](https://github.com/documenso/documenso/commit/459cd5da4465d6681537640f1cc960cb81fb4442) fix(i18n): mark document visibility options for translation - [`b8df918`](https://github.com/documenso/documenso/commit/b8df91818b796ea3b583fab92c7f78d01c45464a) fix(i18n): mark dialogTitle for translation - [`38069e1`](https://github.com/documenso/documenso/commit/38069e1f7e975ceb65d5fb620631cb366c05b41a) Merge branch 'main' into document-visibility ### 📊 Changes **3 files changed** (+17 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx` (+3 -1) 📝 `packages/lib/constants/document-visibility.ts` (+7 -4) 📝 `packages/ui/components/document/document-visibility-select.tsx` (+7 -5) </details> ### 📄 Description ## Description I marked document visibility options for translation. Before: <img width="549" height="319" alt="image" src="https://github.com/user-attachments/assets/13c47105-3000-4900-a9a8-10f81f8a50e4" /> After: <img width="586" height="327" alt="image" src="https://github.com/user-attachments/assets/a2542f89-681d-4a53-9627-c78d58f0ed26" /> ## Changes Made - Mark document visibility options for translation - Mark `Document Settings` header strings with `<Trans>` tag ## Testing Performed - `npm run build` - Check local run - Check `web.po` file ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:57 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2220

No description provided.

Rows
Columns