[PR #2309] [MERGED] fix(i18n): mark sr-only strings for translation #2205

New issue

Closed

opened 2026-02-26 20:32:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2309
Author: @mKoonrad
Created: 12/9/2025
Status: ✅ Merged
Merged: 12/15/2025
Merged by: @dguyen

Base: main ← Head: add-translation-sr-only

📝 Commits (1)

81057d1 fix(i18n): mark sr-only strings for translation

📊 Changes

5 files changed (+26 additions, -8 deletions)

View changed files

📝 apps/remix/app/routes/_authenticated+/o.$orgUrl._index.tsx (+3 -1)
📝 packages/ui/primitives/data-table-pagination.tsx (+12 -4)
📝 packages/ui/primitives/dialog.tsx (+4 -1)
📝 packages/ui/primitives/sheet.tsx (+4 -1)
📝 packages/ui/primitives/signature-pad/signature-pad-draw.tsx (+3 -1)

📄 Description

Description

I marked missing sr-only strings for translation. Previously, only parts of these messages were translatable.

Changes Made

Mark strings to translate with <Trans> tag

Testing Performed

npm run build
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2309 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/15/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `add-translation-sr-only` --- ### 📝 Commits (1) - [`81057d1`](https://github.com/documenso/documenso/commit/81057d1b83d93c138cc1a8548581858c6e0164c8) fix(i18n): mark sr-only strings for translation ### 📊 Changes **5 files changed** (+26 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl._index.tsx` (+3 -1) 📝 `packages/ui/primitives/data-table-pagination.tsx` (+12 -4) 📝 `packages/ui/primitives/dialog.tsx` (+4 -1) 📝 `packages/ui/primitives/sheet.tsx` (+4 -1) 📝 `packages/ui/primitives/signature-pad/signature-pad-draw.tsx` (+3 -1) </details> ### 📄 Description ## Description I marked missing `sr-only` strings for translation. Previously, only parts of these messages were translatable. ## Changes Made - Mark strings to translate with `<Trans>` tag ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2205

No description provided.

Rows
Columns