[PR #2307] [MERGED] chore(i18n): improve punctuation #2202

New issue

Closed

opened 2026-02-26 20:32:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2307
Author: @mKoonrad
Created: 12/9/2025
Status: ✅ Merged
Merged: 12/15/2025
Merged by: @dguyen

Base: main ← Head: change-message-dots

📝 Commits (1)

ddfb4ef chore(i18n): fix punctuation

📊 Changes

19 files changed (+31 additions, -28 deletions)

View changed files

📝 apps/remix/app/components/dialogs/admin-organisation-member-update-dialog.tsx (+2 -2)
📝 apps/remix/app/components/dialogs/envelope-item-delete-dialog.tsx (+1 -1)
📝 apps/remix/app/components/dialogs/organisation-email-domain-records-dialog.tsx (+1 -1)
📝 apps/remix/app/components/dialogs/organisation-member-update-dialog.tsx (+2 -2)
📝 apps/remix/app/components/dialogs/team-member-update-dialog.tsx (+1 -1)
📝 apps/remix/app/components/dialogs/webhook-create-dialog.tsx (+1 -2)
📝 apps/remix/app/components/forms/signin.tsx (+2 -2)
📝 apps/remix/app/components/forms/token.tsx (+1 -1)
📝 apps/remix/app/components/general/document/document-upload-button-legacy.tsx (+2 -2)
📝 apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx (+2 -2)
📝 apps/remix/app/components/general/envelope/envelope-upload-button.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/settings.email.tsx (+1 -1)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+4 -2)
📝 packages/email/template-components/template-footer.tsx (+2 -1)
📝 packages/email/templates/confirm-team-email.tsx (+1 -1)
📝 packages/email/templates/reset-password.tsx (+2 -1)

📄 Description

Description

I fixed inconsistent punctuation (periods) in translation strings.

Changes Made

Added missing periods to setting descriptions so all end consistently.
Moved periods outside of formatting tags (bold or link tags) where they were incorrectly placed inside.
Added missing periods to longer sentences.

Testing Performed

npm run build
Check web.po file

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2307 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/15/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `change-message-dots` --- ### 📝 Commits (1) - [`ddfb4ef`](https://github.com/documenso/documenso/commit/ddfb4ef48e0a6723e0aa9c7d8e3977fd0b7757eb) chore(i18n): fix punctuation ### 📊 Changes **19 files changed** (+31 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/admin-organisation-member-update-dialog.tsx` (+2 -2) 📝 `apps/remix/app/components/dialogs/envelope-item-delete-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/dialogs/organisation-email-domain-records-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/dialogs/organisation-member-update-dialog.tsx` (+2 -2) 📝 `apps/remix/app/components/dialogs/team-member-update-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/dialogs/webhook-create-dialog.tsx` (+1 -2) 📝 `apps/remix/app/components/forms/signin.tsx` (+2 -2) 📝 `apps/remix/app/components/forms/token.tsx` (+1 -1) 📝 `apps/remix/app/components/general/document/document-upload-button-legacy.tsx` (+2 -2) 📝 `apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx` (+2 -2) 📝 `apps/remix/app/components/general/envelope/envelope-upload-button.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/settings.email.tsx` (+1 -1) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+4 -2) 📝 `packages/email/template-components/template-footer.tsx` (+2 -1) 📝 `packages/email/templates/confirm-team-email.tsx` (+1 -1) 📝 `packages/email/templates/reset-password.tsx` (+2 -1) </details> ### 📄 Description ## Description I fixed inconsistent punctuation (periods) in translation strings. ## Changes Made - Added missing periods to setting descriptions so all end consistently. - Moved periods outside of formatting tags (bold or link tags) where they were incorrectly placed inside. - Added missing periods to longer sentences. ## Testing Performed - `npm run build` - Check `web.po` file ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2202

No description provided.

Rows
Columns