[PR #2285] [MERGED] feat: include CC role in removed recipient email check #2185

New issue

Closed

opened 2026-02-26 20:32:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2285
Author: @catalinpit
Created: 12/5/2025
Status: ✅ Merged
Merged: 12/6/2025
Merged by: @Mythie

Base: main ← Head: fix/recipient-cc-role-removal-email

📝 Commits (2)

fd1b2ec feat: include CC role in removed recipient email check
4f9d5da Merge branch 'main' into fix/recipient-cc-role-removal-email

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/lib/server-only/recipient/set-document-recipients.ts (+1 -0)

📄 Description

Description

Include CC role in removed recipient email check to avoid sending a removal email when adding a recipient with the CC role to the document.

At the moment, if you add a recipient with the CC role to a document, that recipient gets an email saying that the CC recipient was removed from the document, which is incorrect. However, now the CC recipients don't get the remove email when they're actually removed from the document.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2285 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 12/5/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/recipient-cc-role-removal-email` --- ### 📝 Commits (2) - [`fd1b2ec`](https://github.com/documenso/documenso/commit/fd1b2ec811f22fbdf9a1bc5c000d4722c5470c24) feat: include CC role in removed recipient email check - [`4f9d5da`](https://github.com/documenso/documenso/commit/4f9d5da2040c35a99357a71aaf88f2b429b854c7) Merge branch 'main' into fix/recipient-cc-role-removal-email ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/recipient/set-document-recipients.ts` (+1 -0) </details> ### 📄 Description ## Description Include CC role in removed recipient email check to avoid sending a removal email when adding a recipient with the CC role to the document. At the moment, if you add a recipient with the CC role to a document, that recipient gets an email saying that the CC recipient was removed from the document, which is incorrect. However, now the CC recipients don't get the remove email when they're actually removed from the document. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:48 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2185

No description provided.

Rows
Columns