starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[GH-ISSUE #742] [🪲 Bug]: Updating profile info without changing anything causes unnecessary database calls #218

New issue

Closed

opened 2026-02-26 18:45:57 +03:00 by kerem · 7 comments

kerem commented

2026-02-26 18:45:57 +03:00

Owner

Originally created by @ashrafchowdury on GitHub (Dec 8, 2023).
Original GitHub issue: https://github.com/documenso/documenso/issues/742

Issue Description

Currently, it is possible to update the profile information without actually changing anything. This is causing unnecessary database calls, which can impact the performance of the application.

Steps to Reproduce

We need to implement a logic to ensure that something is modified before sending a request to the database upon clicking the Update profile button.

Expected Behavior

The profile information has to be updated when something is changed on the profile.

Current Behavior

We can update the profile info without changing anything by clicking the Update profile button

Screenshots (optional)

Here I didn't change anything, but still I can update the profile.

https://github.com/documenso/documenso/assets/87828904/78c3e0cb-6ccc-490e-9c78-e1677a00777c

Operating System [e.g., Windows 10]

Windows 11

Browser [e.g., Chrome, Firefox]

Chrome, Edge

Version [e.g., 2.0.1]

2.0.1

Please check the boxes that apply to this issue report.

I have searched the existing issues to make sure this is not a duplicate.
I have provided steps to reproduce the issue.
I have included relevant environment information.
I have included any relevant screenshots.
I understand that this is a voluntary contribution and that there is no guarantee of resolution.
I want to work on creating a PR for this issue if approved

Originally created by @ashrafchowdury on GitHub (Dec 8, 2023). Original GitHub issue: https://github.com/documenso/documenso/issues/742 ### Issue Description Currently, it is possible to update the profile information without actually changing anything. This is causing unnecessary database calls, which can impact the performance of the application. ### Steps to Reproduce We need to implement a `logic` to ensure that something is modified before sending a request to the database upon clicking the `Update profile` button. ### Expected Behavior The profile information has to be updated when something is changed on the profile. ### Current Behavior We can update the profile info without changing anything by clicking the `Update profile button` ### Screenshots (optional) Here I didn't change anything, but still I can update the profile. https://github.com/documenso/documenso/assets/87828904/78c3e0cb-6ccc-490e-9c78-e1677a00777c ### Operating System [e.g., Windows 10] Windows 11 ### Browser [e.g., Chrome, Firefox] Chrome, Edge ### Version [e.g., 2.0.1] 2.0.1 ### Please check the boxes that apply to this issue report. - [X] I have searched the existing issues to make sure this is not a duplicate. - [X] I have provided steps to reproduce the issue. - [X] I have included relevant environment information. - [X] I have included any relevant screenshots. - [X] I understand that this is a voluntary contribution and that there is no guarantee of resolution. - [X] I want to work on creating a PR for this issue if approved

kerem

2026-02-26 18:45:57 +03:00

closed this issue
added the
type: bug

status: triage
labels

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Dec 8, 2023):

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@github-actions[bot] commented on GitHub (Dec 8, 2023): Thank you for opening your first issue and for being a part of the open signing revolution! <br /> One of our team members will review it and get back to you as soon as it possible 💚 <br /> Meanwhile, please feel free to hop into our community in [Discord](https://documen.so/discord)

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@bilalqv commented on GitHub (Dec 8, 2023):

Team, if this is approved and you want it to be fixed, Then I can work on this issue.

@bilalqv commented on GitHub (Dec 8, 2023): Team, if this is approved and you want it to be fixed, Then I can work on this issue.

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@ashrafchowdury commented on GitHub (Dec 8, 2023):

Team, if this is approved and you want it to be fixed, Then I can work on this issue.

I appreciate your collaborating mindset @crediblebilal. But I raised it to work on this issue.

@ashrafchowdury commented on GitHub (Dec 8, 2023): > Team, if this is approved and you want it to be fixed, Then I can work on this issue. I appreciate your collaborating mindset @crediblebilal. **But I raised it to work on this issue.**

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@bilalqv commented on GitHub (Dec 8, 2023):

No issues @ashrafchowdury , you can take it. 👍

@bilalqv commented on GitHub (Dec 8, 2023): No issues @ashrafchowdury , you can take it. 👍

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@Mythie commented on GitHub (Dec 9, 2023):

Hey there, we've gone over this one before and prefer to just leave it clickable. The database/server trip is negligible and lets the UI remain intuitive 😄

See: #585

@Mythie commented on GitHub (Dec 9, 2023): Hey there, we've gone over this one before and prefer to just leave it clickable. The database/server trip is negligible and lets the UI remain intuitive 😄 See: #585

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@ashrafchowdury commented on GitHub (Dec 9, 2023):

Ohh, I get you @Mythie 💁‍♂️

We can close this issue here.

@ashrafchowdury commented on GitHub (Dec 9, 2023): Ohh, I get you @Mythie 💁‍♂️ We can close this issue here.

kerem commented

2026-02-26 18:45:58 +03:00

Author

Owner

@Mythie commented on GitHub (Dec 9, 2023):

Cheers!

@Mythie commented on GitHub (Dec 9, 2023): Cheers!

kerem referenced this issue

2026-02-26 18:48:59 +03:00

[PR #218] [MERGED] Release 0.9.1 #802

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#218

No description provided.

Rows
Columns