[PR #2263] [MERGED] fix(i18n): mark document visibility strings for translation #2164

New issue

Closed

opened 2026-02-26 20:32:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2263
Author: @mKoonrad
Created: 11/30/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @dguyen

Base: main ← Head: fix(i18n)/2262-add-translation

📝 Commits (2)

59da8b3 fix(i18n): mark strings for translation
9573032 chore: re-run test

📊 Changes

3 files changed (+19 additions, -9 deletions)

View changed files

📝 packages/ui/components/document/document-visibility-select.tsx (+17 -7)
📝 packages/ui/primitives/document-flow/add-settings.tsx (+1 -1)
📝 packages/ui/primitives/template-flow/add-template-settings.tsx (+1 -1)

📄 Description

Description

Fixes #2262

Changes Made

Mark missing strings for translation with <Trans> tag

Testing Performed

npm run build
Check web.po file

#: packages/ui/components/document/document-visibility-select.tsx
msgid "<0>Admins only</0> - Only admins can access and view the document"
msgstr "<0>Admins only</0> - Only admins can access and view the document"

#: packages/ui/components/document/document-visibility-select.tsx
msgid "<0>Everyone</0> - Everyone can access and view the document"
msgstr "<0>Everyone</0> - Everyone can access and view the document"

#: packages/ui/components/document/document-visibility-select.tsx
msgid "<0>Managers and above</0> - Only managers and above can access and view the document"
msgstr "<0>Managers and above</0> - Only managers and above can access and view the document"

#: apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx
#: packages/ui/components/document/document-visibility-select.tsx
#: packages/ui/primitives/document-flow/add-settings.tsx
#: packages/ui/primitives/template-flow/add-template-settings.tsx
msgid "Document visibility"
msgstr "Document visibility"

#: packages/ui/components/document/document-visibility-select.tsx
msgid "The visibility of the document to the recipient."
msgstr "The visibility of the document to the recipient."

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2263 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/30/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix(i18n)/2262-add-translation` --- ### 📝 Commits (2) - [`59da8b3`](https://github.com/documenso/documenso/commit/59da8b3db6d3538922f9824c6ff2a49ca2082f3f) fix(i18n): mark strings for translation - [`9573032`](https://github.com/documenso/documenso/commit/9573032ba494484d299bd4b35e1a42c16854031c) chore: re-run test ### 📊 Changes **3 files changed** (+19 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/components/document/document-visibility-select.tsx` (+17 -7) 📝 `packages/ui/primitives/document-flow/add-settings.tsx` (+1 -1) 📝 `packages/ui/primitives/template-flow/add-template-settings.tsx` (+1 -1) </details> ### 📄 Description ## Description Fixes #2262 ## Changes Made - Mark missing strings for translation with `<Trans>` tag ## Testing Performed - `npm run build` - Check `web.po` file ``` #: packages/ui/components/document/document-visibility-select.tsx msgid "<0>Admins only</0> - Only admins can access and view the document" msgstr "<0>Admins only</0> - Only admins can access and view the document" #: packages/ui/components/document/document-visibility-select.tsx msgid "<0>Everyone</0> - Everyone can access and view the document" msgstr "<0>Everyone</0> - Everyone can access and view the document" #: packages/ui/components/document/document-visibility-select.tsx msgid "<0>Managers and above</0> - Only managers and above can access and view the document" msgstr "<0>Managers and above</0> - Only managers and above can access and view the document" #: apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx #: packages/ui/components/document/document-visibility-select.tsx #: packages/ui/primitives/document-flow/add-settings.tsx #: packages/ui/primitives/template-flow/add-template-settings.tsx msgid "Document visibility" msgstr "Document visibility" #: packages/ui/components/document/document-visibility-select.tsx msgid "The visibility of the document to the recipient." msgstr "The visibility of the document to the recipient." ``` ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2164

No description provided.

Rows
Columns