[PR #2260] [MERGED] fix: prevent client side distribution when missing signatures #2162

Closed
opened 2026-02-26 20:32:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2260
Author: @dguyen
Created: 11/28/2025
Status: Merged
Merged: 12/2/2025
Merged by: @Mythie

Base: mainHead: fix/envelope-distribute-missing-signatures


📝 Commits (1)

  • 297c59f fix: prevent client side distribution when missing signatures

📊 Changes

6 files changed (+78 additions, -55 deletions)

View changed files

📝 apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx (+45 -20)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-header.tsx (+3 -14)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor.tsx (+8 -12)
📝 packages/lib/client-only/providers/envelope-editor-provider.tsx (+17 -2)
📝 packages/trpc/server/envelope-router/set-envelope-fields.ts (+1 -1)
📝 packages/trpc/server/envelope-router/set-envelope-fields.types.ts (+4 -6)

📄 Description

Description

Fixes issue where local fields aren't synced correctly, which allows sending documents without signatures.

Also fixes issue where removing a recipient who has fields will not remove it from the editor when they return to it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2260 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/2/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/envelope-distribute-missing-signatures` --- ### 📝 Commits (1) - [`297c59f`](https://github.com/documenso/documenso/commit/297c59f3f142b42f95ca6cd939c561e9542ca8cf) fix: prevent client side distribution when missing signatures ### 📊 Changes **6 files changed** (+78 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/envelope-distribute-dialog.tsx` (+45 -20) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-header.tsx` (+3 -14) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor.tsx` (+8 -12) 📝 `packages/lib/client-only/providers/envelope-editor-provider.tsx` (+17 -2) 📝 `packages/trpc/server/envelope-router/set-envelope-fields.ts` (+1 -1) 📝 `packages/trpc/server/envelope-router/set-envelope-fields.types.ts` (+4 -6) </details> ### 📄 Description ## Description Fixes issue where local fields aren't synced correctly, which allows sending documents without signatures. Also fixes issue where removing a recipient who has fields will not remove it from the editor when they return to it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:32:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2162
No description provided.