starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #2217] [MERGED] fix(i18n): add pluralization to pagination #2126

New issue

Closed

opened 2026-02-26 20:32:33 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2217
Author: @mKoonrad
Created: 11/19/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @dguyen

Base: main ← Head: fix(i18n)/2171-add-pluralization

📝 Commits (4)

3c9ce9b fix(i18n): add pluralization
79ac8d3 Merge branch 'main' into fix(i18n)/2171-add-pluralization
3b0d71b Merge branch 'main' into fix(i18n)/2171-add-pluralization
15f22da Merge branch 'main' into fix(i18n)/2171-add-pluralization

📊 Changes

1 file changed (+13 additions, -4 deletions)

View changed files

📝 packages/ui/primitives/data-table-pagination.tsx (+13 -4)

📄 Description

Description

Fixes #2171

Changes Made

Add pluralization to pagination message

Testing Performed

npm run build
npm run translate with checking web.po file

#. placeholder {0}: table.getFilteredRowModel().rows.length
#. placeholder {1}: table.getFilteredSelectedRowModel().rows.length
#. placeholder {2}: table.getFilteredSelectedRowModel().rows.length
#: packages/ui/primitives/data-table-pagination.tsx
msgid "{0, plural, one {{1} of # row selected.} other {{2} of # rows selected.}}"
msgstr ""

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Added Trans tag into Plural tag to handle 2 variables at once.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2217 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/19/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix(i18n)/2171-add-pluralization` --- ### 📝 Commits (4) - [`3c9ce9b`](https://github.com/documenso/documenso/commit/3c9ce9b7f4b93a741abc9053fe47ef41538d2d5b) fix(i18n): add pluralization - [`79ac8d3`](https://github.com/documenso/documenso/commit/79ac8d32d9ed4090d0b87255173a942de06d4478) Merge branch 'main' into fix(i18n)/2171-add-pluralization - [`3b0d71b`](https://github.com/documenso/documenso/commit/3b0d71bed2dfc7e22429c0c471b941aa57c36375) Merge branch 'main' into fix(i18n)/2171-add-pluralization - [`15f22da`](https://github.com/documenso/documenso/commit/15f22daa014cce5fb6c5dfb6c7d54681ae160c8f) Merge branch 'main' into fix(i18n)/2171-add-pluralization ### 📊 Changes **1 file changed** (+13 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/data-table-pagination.tsx` (+13 -4) </details> ### 📄 Description ## Description Fixes #2171 ## Changes Made - Add pluralization to pagination message ## Testing Performed - npm run build - npm run translate with checking web.po file ``` #. placeholder {0}: table.getFilteredRowModel().rows.length #. placeholder {1}: table.getFilteredSelectedRowModel().rows.length #. placeholder {2}: table.getFilteredSelectedRowModel().rows.length #: packages/ui/primitives/data-table-pagination.tsx msgid "{0, plural, one {{1} of # row selected.} other {{2} of # rows selected.}}" msgstr "" ``` <img width="832" height="426" alt="image" src="https://github.com/user-attachments/assets/feb46c68-9827-4d48-96eb-7f61825ef1c7" /> ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes Added `Trans` tag into `Plural` tag to handle 2 variables at once. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:33 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2126

No description provided.

Rows
Columns