[PR #2198] [MERGED] fix: invalid email display bug when recipient suggestions on select #2113

New issue

Closed

opened 2026-02-26 20:32:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2198
Author: @filbert-wijaya
Created: 11/15/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @dguyen

Base: main ← Head: fix/invalid-email-display-bug

📝 Commits (1)

c9743b5 fix: invalid email display bug when recipient suggestions on select

📊 Changes

2 files changed (+16 additions, -4 deletions)

View changed files

📝 apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx (+8 -2)
📝 packages/ui/primitives/document-flow/add-signers.tsx (+8 -2)

📄 Description

Description

Fix invalid email display bug after selecting recipient from recipient suggestions autocomplete when adding signees.
It solves the display bug where there is "invalid email" error visually after selecting recipient suggestions autocomplete.

Changes Made

Add shouldValidate and shouldDirty on email field and name field so the fields are validated as soon as recipient suggestions autocomplete is selected, therefore it removes the "invalid email" display bug.

Testing Performed

Tested before fix, "invalid email" appears after selecting recipient suggestions autocomplete
Tested after fix, "invalid email" bug is gone because the fields are validated when selecting suggestions

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2198 **Author:** [@filbert-wijaya](https://github.com/filbert-wijaya) **Created:** 11/15/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/invalid-email-display-bug` --- ### 📝 Commits (1) - [`c9743b5`](https://github.com/documenso/documenso/commit/c9743b54a72b9a2727833a22252478e9111c58bf) fix: invalid email display bug when recipient suggestions on select ### 📊 Changes **2 files changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-recipient-form.tsx` (+8 -2) 📝 `packages/ui/primitives/document-flow/add-signers.tsx` (+8 -2) </details> ### 📄 Description ## Description Fix invalid email display bug after selecting recipient from recipient suggestions autocomplete when adding signees. It solves the display bug where there is "invalid email" error visually after selecting recipient suggestions autocomplete. ## Changes Made - Add shouldValidate and shouldDirty on email field and name field so the fields are validated as soon as recipient suggestions autocomplete is selected, therefore it removes the "invalid email" display bug. ## Testing Performed - Tested before fix, "invalid email" appears after selecting recipient suggestions autocomplete - Tested after fix, "invalid email" bug is gone because the fields are validated when selecting suggestions ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2113

No description provided.

Rows
Columns