starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #2183] [MERGED] fix(i18n): add pluralization to envelope items #2105

New issue

Closed

opened 2026-02-26 20:32:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2183
Author: @mKoonrad
Created: 11/12/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @dguyen

Base: main ← Head: fix(i18n)/2101-add-pluralization

📝 Commits (5)

9086a24 fix(i18n): add pluralization
741ef99 Merge branch 'main' into fix(i18n)/2101-add-pluralization
c7d8663 chore: re-run test
66d07d3 Merge branch 'main' into fix(i18n)/2101-add-pluralization
bfe70e2 fix(i18n): add pluralization

📊 Changes

3 files changed (+21 additions, -6 deletions)

View changed files

📝 apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx (+11 -3)
📝 apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx (+5 -1)
📝 apps/remix/app/components/general/envelope/envelope-upload-button.tsx (+5 -2)

📄 Description

Description

Fixes #2101

Changes Made

Add pluralization for messages with ${maximumEnvelopeItemCount} variable

Testing Performed

npm run build
npm run translate with checking web.po file

Before:

#: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx
#: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx
#: apps/remix/app/components/general/envelope/envelope-upload-button.tsx
#: apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx
msgid "You cannot upload more than {maximumEnvelopeItemCount} items per envelope."
msgstr ""

After:

#: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx
#: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx
#: apps/remix/app/components/general/envelope/envelope-upload-button.tsx
#: apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx
msgid "{maximumEnvelopeItemCount, plural, one {You cannot upload more than # item per envelope.} other {You cannot upload more than # items per envelope.}}"
msgstr ""

Crowdin view:

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Pluralization added by ICU MessageFormat

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2183 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/12/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix(i18n)/2101-add-pluralization` --- ### 📝 Commits (5) - [`9086a24`](https://github.com/documenso/documenso/commit/9086a24a04ed84aa69ab73498eb3b53bd07e7701) fix(i18n): add pluralization - [`741ef99`](https://github.com/documenso/documenso/commit/741ef991a34725afa7b2a45cedf5396b8e2b54b1) Merge branch 'main' into fix(i18n)/2101-add-pluralization - [`c7d8663`](https://github.com/documenso/documenso/commit/c7d86634f984b93f753189e70765d66cbf981719) chore: re-run test - [`66d07d3`](https://github.com/documenso/documenso/commit/66d07d3a36bbe7e189f42415a7407060f7b59dca) Merge branch 'main' into fix(i18n)/2101-add-pluralization - [`bfe70e2`](https://github.com/documenso/documenso/commit/bfe70e283cad5c729f4f6629bcb5b8d9ad1f9dc4) fix(i18n): add pluralization ### 📊 Changes **3 files changed** (+21 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx` (+11 -3) 📝 `apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx` (+5 -1) 📝 `apps/remix/app/components/general/envelope/envelope-upload-button.tsx` (+5 -2) </details> ### 📄 Description ## Description Fixes #2101 ## Changes Made - Add pluralization for messages with `${maximumEnvelopeItemCount}` variable ## Testing Performed   - npm run build - npm run translate with checking web.po file Before: ``` #: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx #: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx #: apps/remix/app/components/general/envelope/envelope-upload-button.tsx #: apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx msgid "You cannot upload more than {maximumEnvelopeItemCount} items per envelope." msgstr "" ``` After: ``` #: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx #: apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx #: apps/remix/app/components/general/envelope/envelope-upload-button.tsx #: apps/remix/app/components/general/envelope/envelope-drop-zone-wrapper.tsx msgid "{maximumEnvelopeItemCount, plural, one {You cannot upload more than # item per envelope.} other {You cannot upload more than # items per envelope.}}" msgstr "" ``` Crowdin view: <img width="950" height="414" alt="image" src="https://github.com/user-attachments/assets/260e5bb0-efed-44a4-ae25-134743caf1de" /> ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [ ] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes Pluralization added by ICU MessageFormat --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:27 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2105

No description provided.

Rows
Columns