[PR #2177] [MERGED] fix: include cmaps for pdf viewer #2098

New issue

Closed

opened 2026-02-26 20:32:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2177
Author: @Mythie
Created: 11/11/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @Mythie

Base: main ← Head: fix/pdf-viewer-cmaps

📝 Commits (1)

e7a8799 fix: include cmaps for pdf viewer

📊 Changes

8 files changed (+138 additions, -33 deletions)

View changed files

📝 apps/remix/vite.config.ts (+16 -1)
📝 docker/Dockerfile (+2 -1)
📝 package-lock.json (+85 -11)
📝 package.json (+10 -9)
📝 packages/lib/server-only/pdf/insert-field-in-pdf-v2.ts (+10 -8)
📝 packages/lib/universal/field-renderer/field-generic-items.ts (+1 -1)
📝 packages/ui/components/pdf-viewer/pdf-viewer-konva.tsx (+6 -0)
📝 packages/ui/primitives/pdf-viewer.tsx (+8 -2)

📄 Description

We were previously omitting cmaps meaning that
when signing documents with certain UTF-8 characters or CJK characters they would appear as outlined squares in the pdf viewer despite the actual pdf looking as expected with the characters displaying correctly.

Before:

After:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2177 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/pdf-viewer-cmaps` --- ### 📝 Commits (1) - [`e7a8799`](https://github.com/documenso/documenso/commit/e7a8799ed2612c2dbdc17c30af955114dd86de9a) fix: include cmaps for pdf viewer ### 📊 Changes **8 files changed** (+138 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/vite.config.ts` (+16 -1) 📝 `docker/Dockerfile` (+2 -1) 📝 `package-lock.json` (+85 -11) 📝 `package.json` (+10 -9) 📝 `packages/lib/server-only/pdf/insert-field-in-pdf-v2.ts` (+10 -8) 📝 `packages/lib/universal/field-renderer/field-generic-items.ts` (+1 -1) 📝 `packages/ui/components/pdf-viewer/pdf-viewer-konva.tsx` (+6 -0) 📝 `packages/ui/primitives/pdf-viewer.tsx` (+8 -2) </details> ### 📄 Description We were previously omitting cmaps meaning that when signing documents with certain UTF-8 characters or CJK characters they would appear as outlined squares in the pdf viewer despite the actual pdf looking as expected with the characters displaying correctly. **Before:** <img width="596" height="217" alt="image" src="https://github.com/user-attachments/assets/8e3cf2a7-f3cd-4e89-bbd7-255e3bb8ccbd" /> **After:** <img width="528" height="330" alt="image" src="https://github.com/user-attachments/assets/431eace9-de05-415c-a18f-5f738b4b93a3" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2098

No description provided.

Rows
Columns