starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #2172] [MERGED] chore(i18n): change recipient invitation messages #2094

New issue

Closed

opened 2026-02-26 20:32:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2172
Author: @mKoonrad
Created: 11/11/2025
Status: ✅ Merged
Merged: 12/3/2025
Merged by: @dguyen

Base: main ← Head: chore(i18n)/2121-change-message

📝 Commits (7)

c9e07f3 chore(i18n): change message
4a3a8fa chore: re-run test
3d0e6d1 chore: re-run test
b5f0b0e chore: re-run test
ad49ebf chore: re-run test
fba1724 Merge branch 'main' into chore(i18n)/2121-change-message
78b4815 Merge branch 'main' into chore(i18n)/2121-change-message

📊 Changes

1 file changed (+36 additions, -7 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (+36 -7)

📄 Description

Description

Fixes #2121

Changes Made

Add variable inside <Trans> component to provide full context and allow for flexible translations.

Testing Performed

npm run build
Upload web.po to Crowdin interface to check correct format of new strings

Manual web.po check

#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> has invited you to approve this document"
msgstr ""

#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> has invited you to assist this document"
msgstr ""

#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> has invited you to sign this document"
msgstr ""

#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> has invited you to view this document"
msgstr ""

#. placeholder {0}: document.team?.name
#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to approve this document"
msgstr ""

#. placeholder {0}: document.team?.name
#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to assist this document"
msgstr ""

#. placeholder {0}: document.team?.name
#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to sign this document"
msgstr ""

#. placeholder {0}: document.team?.name
#: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx
msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to view this document"
msgstr ""

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2172 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/11/2025 **Status:** ✅ Merged **Merged:** 12/3/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `chore(i18n)/2121-change-message` --- ### 📝 Commits (7) - [`c9e07f3`](https://github.com/documenso/documenso/commit/c9e07f3fbf15b3cadc46796b150346f85f720550) chore(i18n): change message - [`4a3a8fa`](https://github.com/documenso/documenso/commit/4a3a8fa2148b14cdf76ffdf22e2ddcedc9cd3b30) chore: re-run test - [`3d0e6d1`](https://github.com/documenso/documenso/commit/3d0e6d168c6d2d33670774ee069b3a12976e298d) chore: re-run test - [`b5f0b0e`](https://github.com/documenso/documenso/commit/b5f0b0e50a91f6c26298e6212f4b773e2a6c2bbe) chore: re-run test - [`ad49ebf`](https://github.com/documenso/documenso/commit/ad49ebfc0e2f9b8eca2937d9e63fcf0fe2e1a197) chore: re-run test - [`fba1724`](https://github.com/documenso/documenso/commit/fba1724663af9d031482f4eb662894cd8a9576f6) Merge branch 'main' into chore(i18n)/2121-change-message - [`78b4815`](https://github.com/documenso/documenso/commit/78b481531a9bd644bf7cfb2124faf9eff87396bf) Merge branch 'main' into chore(i18n)/2121-change-message ### 📊 Changes **1 file changed** (+36 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx` (+36 -7) </details> ### 📄 Description ## Description Fixes #2121 ## Changes Made Add variable inside `<Trans>` component to provide full context and allow for flexible translations. ## Testing Performed - `npm run build` - Upload web.po to Crowdin interface to check correct format of new strings <img width="1881" height="570" alt="image" src="https://github.com/user-attachments/assets/cf988343-6c9d-46dd-8ae6-0e5e141ef032" /> - Manual web.po check ``` #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> has invited you to approve this document" msgstr "" #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> has invited you to assist this document" msgstr "" #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> has invited you to sign this document" msgstr "" #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> has invited you to view this document" msgstr "" #. placeholder {0}: document.team?.name #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to approve this document" msgstr "" #. placeholder {0}: document.team?.name #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to assist this document" msgstr "" #. placeholder {0}: document.team?.name #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to sign this document" msgstr "" #. placeholder {0}: document.team?.name #: apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx msgid "<0>{senderName} {senderEmail}</0> on behalf of \"{0}\" has invited you to view this document" msgstr "" ``` ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:24 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2094

No description provided.

Rows
Columns