starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #2155] fix: add page titles for translation #2082

New issue

Open

opened 2026-02-26 20:32:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2155
Author: @BKM14
Created: 11/8/2025
Status: 🔄 Open

Base: main ← Head: fix/mark-titles-for-translation

📝 Commits (1)

b812776 fix: add page titles for translation

📊 Changes

40 files changed (+72 additions, -41 deletions)

View changed files

📝 apps/remix/app/routes/_authenticated+/dashboard.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/inbox.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings._layout.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.billing.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email-domains._index.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.general.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.sso.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.support.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/_layout.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/profile.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/security._index.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/security.activity.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/security.linked-accounts.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/security.passkeys.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/settings+/security.sessions.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents._index.tsx (+2 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx (+2 -1)

...and 20 more files

📄 Description

Description

The title of the page being displayed on the tab was not translated previously. Despite changing the language in the settings, the title of the tab would still be displayed in English.

Closes #2142

Changes Made

The title parameter passed to appMetaTags is now of type MessageDescriptor rather than a simple string.
All usages of appMetaTags have been modified to use msg while passing the title of the page.

Testing Performed

I was able to build the project without facing any build issues.
I verified that the titles were being translated after changing the language. Will be attaching a screenshot of the same.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2155 **Author:** [@BKM14](https://github.com/BKM14) **Created:** 11/8/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/mark-titles-for-translation` --- ### 📝 Commits (1) - [`b812776`](https://github.com/documenso/documenso/commit/b81277683631f37ceec52381834736fda2dfebfe) fix: add page titles for translation ### 📊 Changes **40 files changed** (+72 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/routes/_authenticated+/dashboard.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/inbox.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings._layout.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.billing.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email-domains._index.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.general.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.sso.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.support.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/_layout.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/profile.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/security._index.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/security.activity.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/security.linked-accounts.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/security.passkeys.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/settings+/security.sessions.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents._index.tsx` (+2 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx` (+2 -1) _...and 20 more files_ </details> ### 📄 Description ## Description The title of the page being displayed on the tab was not translated previously. Despite changing the language in the settings, the title of the tab would still be displayed in English. ## Related Issue Closes #2142 ## Changes Made - The `title` parameter passed to `appMetaTags` is now of type `MessageDescriptor` rather than a simple `string`. - All usages of `appMetaTags` have been modified to use `msg` while passing the title of the page. ## Testing Performed - I was able to build the project without facing any build issues. - I verified that the titles were being translated after changing the language. Will be attaching a screenshot of the same. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/6f66602b-29ef-4f84-a943-e68286840ec2" /> <img width="1920" height="1040" alt="image" src="https://github.com/user-attachments/assets/9e5961a4-b87e-4d05-acaf-072cfed902d6" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-26 20:32:21 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2082

No description provided.

Rows
Columns