starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #2154] [MERGED] feat: add additional field options #2080

New issue

Closed

opened 2026-02-26 20:32:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2154
Author: @dguyen
Created: 11/8/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @dguyen

Base: main ← Head: feat/add-additional-field-options

📝 Commits (4)

4b39717 feat: add additional field options
d9da53b fix: test
6389b0a fix: reset images
b297934 fix: reduce threshold

📊 Changes

46 files changed (+1017 additions, -328 deletions)

View changed files

📝 apps/remix/app/components/forms/editor/editor-field-date-form.tsx (+2 -1)
📝 apps/remix/app/components/forms/editor/editor-field-email-form.tsx (+2 -1)
📝 apps/remix/app/components/forms/editor/editor-field-generic-field-forms.tsx (+117 -0)
📝 apps/remix/app/components/forms/editor/editor-field-initials-form.tsx (+2 -1)
📝 apps/remix/app/components/forms/editor/editor-field-name-form.tsx (+2 -1)
📝 apps/remix/app/components/forms/editor/editor-field-number-form.tsx (+30 -4)
📝 apps/remix/app/components/forms/editor/editor-field-signature-form.tsx (+3 -6)
📝 apps/remix/app/components/forms/editor/editor-field-text-form.tsx (+53 -30)
📝 apps/remix/app/components/general/document/document-certificate-qr-view.tsx (+11 -4)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-preview-page.tsx (+5 -2)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx (+9 -1)
📝 apps/remix/app/components/general/envelope-editor/envelope-generic-page-renderer.tsx (+16 -7)
📝 apps/remix/app/components/general/envelope-signing/envelope-signer-page-renderer.tsx (+96 -12)
📝 assets/field-font-alignment.pdf (+0 -0)
📝 packages/app-tests/constants/field-alignment-pdf.ts (+384 -141)
📝 packages/app-tests/constants/field-meta-pdf.ts (+24 -20)
📝 packages/app-tests/e2e/api/v2/envelopes-api.spec.ts (+3 -3)
📝 packages/app-tests/e2e/envelopes/envelope-alignment.spec.ts (+29 -2)
➕ packages/app-tests/visual-regression/alignment-pdf-0.png (+0 -0)
➕ packages/app-tests/visual-regression/alignment-pdf-1.png (+0 -0)

...and 26 more files

📄 Description

Description

Sealing changes:

Always place radio/checkbox fields into PDF regardless if inserted or not
Always place read-only fields into PDFs

Text/Number field changes:

Add vertical alignment (defaults to middle alignment)
Add letter spacing
Add line height
Remove Y padding for better multi line support

Editor fixes:

Clean up fields and renderer when envelope items deleted

Signing page changes:

Show other recipient fields if they have fully signed

Other:

Finalize visual regression testing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2154 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 11/8/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `feat/add-additional-field-options` --- ### 📝 Commits (4) - [`4b39717`](https://github.com/documenso/documenso/commit/4b3971703b087cf199c4cab79a7d6c46364df9b8) feat: add additional field options - [`d9da53b`](https://github.com/documenso/documenso/commit/d9da53b8f7f6adf3607b12ff91e9b82cba8eedb0) fix: test - [`6389b0a`](https://github.com/documenso/documenso/commit/6389b0aeb8658b8c4766294f20f36a6e1f131ef9) fix: reset images - [`b297934`](https://github.com/documenso/documenso/commit/b297934aa470ceaec15b87eeb64cf31e27a015d2) fix: reduce threshold ### 📊 Changes **46 files changed** (+1017 additions, -328 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/forms/editor/editor-field-date-form.tsx` (+2 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-email-form.tsx` (+2 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-generic-field-forms.tsx` (+117 -0) 📝 `apps/remix/app/components/forms/editor/editor-field-initials-form.tsx` (+2 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-name-form.tsx` (+2 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-number-form.tsx` (+30 -4) 📝 `apps/remix/app/components/forms/editor/editor-field-signature-form.tsx` (+3 -6) 📝 `apps/remix/app/components/forms/editor/editor-field-text-form.tsx` (+53 -30) 📝 `apps/remix/app/components/general/document/document-certificate-qr-view.tsx` (+11 -4) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-preview-page.tsx` (+5 -2) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-upload-page.tsx` (+9 -1) 📝 `apps/remix/app/components/general/envelope-editor/envelope-generic-page-renderer.tsx` (+16 -7) 📝 `apps/remix/app/components/general/envelope-signing/envelope-signer-page-renderer.tsx` (+96 -12) 📝 `assets/field-font-alignment.pdf` (+0 -0) 📝 `packages/app-tests/constants/field-alignment-pdf.ts` (+384 -141) 📝 `packages/app-tests/constants/field-meta-pdf.ts` (+24 -20) 📝 `packages/app-tests/e2e/api/v2/envelopes-api.spec.ts` (+3 -3) 📝 `packages/app-tests/e2e/envelopes/envelope-alignment.spec.ts` (+29 -2) ➕ `packages/app-tests/visual-regression/alignment-pdf-0.png` (+0 -0) ➕ `packages/app-tests/visual-regression/alignment-pdf-1.png` (+0 -0) _...and 26 more files_ </details> ### 📄 Description ## Description Sealing changes: - Always place radio/checkbox fields into PDF regardless if inserted or not - Always place read-only fields into PDFs Text/Number field changes: - Add vertical alignment **(defaults to middle alignment)** - Add letter spacing - Add line height - Remove Y padding for better multi line support Editor fixes: - Clean up fields and renderer when envelope items deleted Signing page changes: - Show other recipient fields if they have fully signed Other: - Finalize visual regression testing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:20 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:33:10 +03:00

[PR #2391] feat: support zoom in preview #2270

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2080

No description provided.

Rows
Columns