starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-26 06:15:58 +03:00

[PR #2136] [MERGED] chore(i18n): add message context in EnvelopeDownloadDialog #2068

New issue

Closed

opened 2026-02-26 20:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2136
Author: @mKoonrad
Created: 11/6/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @dguyen

Base: main ← Head: chore(i18n)/2100-add-context

📝 Commits (1)

404a72e chore(i18n): add message context

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 apps/remix/app/components/dialogs/envelope-download-dialog.tsx (+2 -2)

📄 Description

Description

Fixes #2100

Changes Made

Add context to strings

Testing Performed

npm run build

web.po before:

#: apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx
#: apps/remix/app/components/general/document/document-page-view-recipients.tsx
#: apps/remix/app/components/dialogs/envelope-download-dialog.tsx
#: packages/ui/components/document/document-read-only-fields.tsx
msgid "Signed"
msgstr "Signed"

web.po after:

#: apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx
#: apps/remix/app/components/general/document/document-page-view-recipients.tsx
#: packages/ui/components/document/document-read-only-fields.tsx
msgid "Signed"
msgstr "Signed"

#: apps/remix/app/components/dialogs/envelope-download-dialog.tsx
msgctxt "Signed document (adjective)"
msgid "Signed"
msgstr "Signed"

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2136 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/6/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `chore(i18n)/2100-add-context` --- ### 📝 Commits (1) - [`404a72e`](https://github.com/documenso/documenso/commit/404a72e4cbc2c79e95f7c943371a0bb92aa61a0c) chore(i18n): add message context ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/envelope-download-dialog.tsx` (+2 -2) </details> ### 📄 Description ## Description Fixes #2100 ## Changes Made Add context to strings ## Testing Performed - `npm run build` `web.po` before: ``` #: apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx #: apps/remix/app/components/general/document/document-page-view-recipients.tsx #: apps/remix/app/components/dialogs/envelope-download-dialog.tsx #: packages/ui/components/document/document-read-only-fields.tsx msgid "Signed" msgstr "Signed" ``` `web.po` after: ``` #: apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx #: apps/remix/app/components/general/document/document-page-view-recipients.tsx #: packages/ui/components/document/document-read-only-fields.tsx msgid "Signed" msgstr "Signed" #: apps/remix/app/components/dialogs/envelope-download-dialog.tsx msgctxt "Signed document (adjective)" msgid "Signed" msgstr "Signed" ``` ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:18 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2068

No description provided.

Rows
Columns