[PR #2129] [MERGED] fix(i18n): add pluralization to passkey page #2065

New issue

Closed

opened 2026-02-26 20:32:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2129
Author: @mKoonrad
Created: 11/4/2025
Status: ✅ Merged
Merged: 11/10/2025
Merged by: @dguyen

Base: main ← Head: fix(i18n)/2112-add-pluralization

📝 Commits (1)

ee871c6 fix(i18n): add pluralization to passkey page

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 apps/remix/app/components/dialogs/passkey-create-dialog.tsx (+6 -2)

📄 Description

Description

Fixes #2112

Changes Made

Add pluralization

Testing Performed

npm run translate with checking web.po file
npm run build

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

In English, there is one singular and one plural form. In many other languages (like Polish) there are more plural forms (few and many). Even when you use only plural case (>1), pluralization is needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2129 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 11/10/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix(i18n)/2112-add-pluralization` --- ### 📝 Commits (1) - [`ee871c6`](https://github.com/documenso/documenso/commit/ee871c6c9932d108711d33dff9ad2bbef6cddda0) fix(i18n): add pluralization to passkey page ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/passkey-create-dialog.tsx` (+6 -2) </details> ### 📄 Description ## Description Fixes #2112 ## Changes Made   - Add pluralization ## Testing Performed - `npm run translate` with checking web.po file - `npm run build` ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes In English, there is one singular and one plural form. In many other languages (like Polish) there are more plural forms (few and many). Even when you use only plural case (>1), pluralization is needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:17 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2065

No description provided.

Rows
Columns