[PR #2072] [MERGED] fix: on error job should resubmit with isRetry #2032

New issue

Closed

opened 2026-02-26 20:32:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2072
Author: @rwagoner
Created: 10/10/2025
Status: ✅ Merged
Merged: 12/15/2025
Merged by: @dguyen

Base: main ← Head: fix/job-retry

📝 Commits (1)

4ded88b fix: on error job should resubmit with isRetry

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 packages/lib/jobs/client/local.ts (+1 -0)

📄 Description

Description

When a job encounters an error and is submitted to run again the retried counter is not incremented. This causes the job to retry indefinitely for the duration the app runs.

Changes Made

Set the isRetry job when calling submitJobToEndpoint in the try catch.

Testing Performed

Tested locally and retired is incremented until maxRetries is hit. Then the job is correctly set to FAILED.

Checklist

[ X] I have tested these changes locally and they work as expected.
[X ] I have followed the project's coding style guidelines.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2072 **Author:** [@rwagoner](https://github.com/rwagoner) **Created:** 10/10/2025 **Status:** ✅ Merged **Merged:** 12/15/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/job-retry` --- ### 📝 Commits (1) - [`4ded88b`](https://github.com/documenso/documenso/commit/4ded88b304233aa29e166d6bcc7ca2fd2d26257d) fix: on error job should resubmit with isRetry ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/jobs/client/local.ts` (+1 -0) </details> ### 📄 Description ## Description When a job encounters an error and is submitted to run again the retried counter is not incremented. This causes the job to retry indefinitely for the duration the app runs. ## Related Issue   ## Changes Made Set the isRetry job when calling submitJobToEndpoint in the try catch. ## Testing Performed   Tested locally and retired is incremented until maxRetries is hit. Then the job is correctly set to FAILED. ## Checklist   - [ X] I have tested these changes locally and they work as expected. - [X ] I have followed the project's coding style guidelines. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:08 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2032

No description provided.

Rows
Columns