[PR #2064] [CLOSED] fix(email): add missing translations in signing invite #2025

Closed
opened 2026-02-26 20:32:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2064
Author: @mehmetsungurmutlu
Created: 10/6/2025
Status: Closed

Base: mainHead: fix-sign-invite-translations


📝 Commits (2)

  • cbb2a7b fix(email): add missing translations in signing invite
  • a86250b Merge branch 'main' into fix-sign-invite-translations

📊 Changes

6 files changed (+411 additions, -15 deletions)

View changed files

📝 packages/lib/translations/de/web.po (+69 -3)
📝 packages/lib/translations/en/web.po (+66 -0)
📝 packages/lib/translations/es/web.po (+69 -3)
📝 packages/lib/translations/fr/web.po (+69 -3)
📝 packages/lib/translations/it/web.po (+69 -3)
📝 packages/lib/translations/pl/web.po (+69 -3)

📄 Description

Description

Fix missing translations in the signing invite email. After updating to version 1.12.7, some words like "sign" were not properly translated in non-English languages. This PR ensures that all translations appear correctly.

Addresses #ISSUE_NUMBER (replace with the actual GitHub issue number).

Changes Made

  • Updated .po translation files to include missing entries.
  • Verified that "sign" now appears as "signer" in French.

Testing Performed

  • Sent a test signing request email in French and verified that translations display correctly.
  • Checked other major languages for missing translations.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Manual translation extraction was performed for this PR. Future commits should automate this process to prevent missing translations.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2064 **Author:** [@mehmetsungurmutlu](https://github.com/mehmetsungurmutlu) **Created:** 10/6/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-sign-invite-translations` --- ### 📝 Commits (2) - [`cbb2a7b`](https://github.com/documenso/documenso/commit/cbb2a7bc63ef6fd4ae792aed41d92f912440473e) fix(email): add missing translations in signing invite - [`a86250b`](https://github.com/documenso/documenso/commit/a86250bfbf2276381c3e6e70b7fa20dc41bb244f) Merge branch 'main' into fix-sign-invite-translations ### 📊 Changes **6 files changed** (+411 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/translations/de/web.po` (+69 -3) 📝 `packages/lib/translations/en/web.po` (+66 -0) 📝 `packages/lib/translations/es/web.po` (+69 -3) 📝 `packages/lib/translations/fr/web.po` (+69 -3) 📝 `packages/lib/translations/it/web.po` (+69 -3) 📝 `packages/lib/translations/pl/web.po` (+69 -3) </details> ### 📄 Description ## Description Fix missing translations in the signing invite email. After updating to version 1.12.7, some words like "sign" were not properly translated in non-English languages. This PR ensures that all translations appear correctly. ## Related Issue Addresses #ISSUE_NUMBER (replace with the actual GitHub issue number). ## Changes Made - Updated `.po` translation files to include missing entries. - Verified that "sign" now appears as "signer" in French. ## Testing Performed - Sent a test signing request email in French and verified that translations display correctly. - Checked other major languages for missing translations. ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes Manual translation extraction was performed for this PR. Future commits should automate this process to prevent missing translations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:32:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2025
No description provided.