[PR #2063] [MERGED] feat: support 2fa for document completion #2023

New issue

Closed

opened 2026-02-26 20:32:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2063
Author: @Mythie
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @Mythie

Base: main ← Head: feat/2fa-document-completion-auth

📝 Commits (1)

6cc4e59 feat: support 2fa for document completion

📊 Changes

31 files changed (+1297 additions, -257 deletions)

View changed files

📝 .gitignore (+4 -1)
📝 apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx (+2 -2)
➕ apps/remix/app/components/general/document-signing/access-auth-2fa-form.tsx (+312 -0)
📝 apps/remix/app/components/general/document-signing/document-signing-complete-dialog.tsx (+242 -183)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+17 -14)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+19 -10)
📝 apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx (+1 -0)
📝 apps/remix/app/routes/_recipient+/d.$token+/_index.tsx (+6 -4)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+9 -8)
📝 apps/remix/app/routes/embed+/_v0+/direct.$url.tsx (+6 -4)
📝 apps/remix/app/routes/embed+/_v0+/sign.$url.tsx (+6 -4)
➕ packages/email/template-components/template-access-auth-2fa.tsx (+60 -0)
➕ packages/email/templates/access-auth-2fa.tsx (+77 -0)
📝 packages/lib/errors/app-error.ts (+2 -0)
➕ packages/lib/server-only/2fa/email/constants.ts (+1 -0)
➕ packages/lib/server-only/2fa/email/generate-2fa-credentials-from-email.ts (+38 -0)
➕ packages/lib/server-only/2fa/email/generate-2fa-token-from-email.ts (+23 -0)
➕ packages/lib/server-only/2fa/email/send-2fa-token-email.ts (+124 -0)
➕ packages/lib/server-only/2fa/email/validate-2fa-token-from-email.ts (+37 -0)
📝 packages/lib/server-only/document/complete-document-with-token.ts (+54 -16)

...and 11 more files

📄 Description

Adds support for 2FA when completing a document, also adds support for using email for 2FA when no authenticator has been associated with the account.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2063 **Author:** [@Mythie](https://github.com/Mythie) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `feat/2fa-document-completion-auth` --- ### 📝 Commits (1) - [`6cc4e59`](https://github.com/documenso/documenso/commit/6cc4e5960084ea0558024e45ff8c1a7fecebe900) feat: support 2fa for document completion ### 📊 Changes **31 files changed** (+1297 additions, -257 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+4 -1) 📝 `apps/remix/app/components/general/direct-template/direct-template-signing-form.tsx` (+2 -2) ➕ `apps/remix/app/components/general/document-signing/access-auth-2fa-form.tsx` (+312 -0) 📝 `apps/remix/app/components/general/document-signing/document-signing-complete-dialog.tsx` (+242 -183) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+17 -14) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+19 -10) 📝 `apps/remix/app/routes/_internal+/[__htmltopdf]+/certificate.tsx` (+1 -0) 📝 `apps/remix/app/routes/_recipient+/d.$token+/_index.tsx` (+6 -4) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+9 -8) 📝 `apps/remix/app/routes/embed+/_v0+/direct.$url.tsx` (+6 -4) 📝 `apps/remix/app/routes/embed+/_v0+/sign.$url.tsx` (+6 -4) ➕ `packages/email/template-components/template-access-auth-2fa.tsx` (+60 -0) ➕ `packages/email/templates/access-auth-2fa.tsx` (+77 -0) 📝 `packages/lib/errors/app-error.ts` (+2 -0) ➕ `packages/lib/server-only/2fa/email/constants.ts` (+1 -0) ➕ `packages/lib/server-only/2fa/email/generate-2fa-credentials-from-email.ts` (+38 -0) ➕ `packages/lib/server-only/2fa/email/generate-2fa-token-from-email.ts` (+23 -0) ➕ `packages/lib/server-only/2fa/email/send-2fa-token-email.ts` (+124 -0) ➕ `packages/lib/server-only/2fa/email/validate-2fa-token-from-email.ts` (+37 -0) 📝 `packages/lib/server-only/document/complete-document-with-token.ts` (+54 -16) _...and 11 more files_ </details> ### 📄 Description Adds support for 2FA when completing a document, also adds support for using email for 2FA when no authenticator has been associated with the account. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2023

No description provided.

Rows
Columns