[PR #2051] [MERGED] fix: add context to signature pad translations #2017

New issue

Closed

opened 2026-02-26 20:32:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:32:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2051
Author: @samuel-cglg
Created: 9/26/2025
Status: ✅ Merged
Merged: 11/13/2025
Merged by: @dguyen

Base: main ← Head: fix-signature-pad-translations

📝 Commits (2)

6e9d1e3 fix: add comment to signature pad translations
1b14aae fix: merge signature pad translations with constants/documents.ts thanks to translation context

📊 Changes

2 files changed (+7 additions, -7 deletions)

View changed files

📝 packages/lib/constants/document.ts (+3 -3)
📝 packages/ui/primitives/signature-pad/signature-pad.tsx (+4 -4)

📄 Description

Description

Add comments to signature pad translations for the words "Type", "Draw" and "Upload".
As suggested by @mKoonrad in https://github.com/documenso/documenso/pull/2007#issuecomment-3271878718, it will help differentiate these words.

This is an improvement of https://github.com/documenso/documenso/pull/2007

Changes Made

Testing Performed

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2051 **Author:** [@samuel-cglg](https://github.com/samuel-cglg) **Created:** 9/26/2025 **Status:** ✅ Merged **Merged:** 11/13/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix-signature-pad-translations` --- ### 📝 Commits (2) - [`6e9d1e3`](https://github.com/documenso/documenso/commit/6e9d1e359b0d206d2c8f93073f028a2776099b18) fix: add comment to signature pad translations - [`1b14aae`](https://github.com/documenso/documenso/commit/1b14aae9c04815df2b3cef0c8dabe6032ae92af1) fix: merge signature pad translations with constants/documents.ts thanks to translation context ### 📊 Changes **2 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/constants/document.ts` (+3 -3) 📝 `packages/ui/primitives/signature-pad/signature-pad.tsx` (+4 -4) </details> ### 📄 Description ## Description Add comments to signature pad translations for the words "Type", "Draw" and "Upload". As suggested by @mKoonrad in https://github.com/documenso/documenso/pull/2007#issuecomment-3271878718, it will help differentiate these words. ## Related Issue This is an improvement of https://github.com/documenso/documenso/pull/2007 ## Changes Made   ## Testing Performed   ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:32:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#2017

No description provided.

Rows
Columns