[PR #2038] [MERGED] fix: allow dates with and without time #2008

Closed
opened 2026-02-26 20:32:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/2038
Author: @catalinpit
Created: 9/18/2025
Status: Merged
Merged: 9/24/2025
Merged by: @catalinpit

Base: mainHead: fix/date-formats


📝 Commits (3)

  • 9fdc964 fix: allow dates with and without time
  • 7780c74 Merge branch 'main' into fix/date-formats
  • 85996c3 chore: standardize date formats to use 24-hour time

📊 Changes

1 file changed (+59 additions, -33 deletions)

View changed files

📝 packages/lib/constants/date-formats.ts (+59 -33)

📄 Description

Description

This PR extends the date formatting options to include both date-only and date-time formats.

  • Added 6 new date-only format patterns to VALID_DATE_FORMAT_VALUES
  • Extended DATE_FORMATS array with 7 new date-only format options
  • Reorganized formats into two clear sections: date-time and date-only
  • Fixed duplicate key issues by adding _TIME suffix to date-time format keys where conflicts existed

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/2038 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@catalinpit](https://github.com/catalinpit) **Base:** `main` ← **Head:** `fix/date-formats` --- ### 📝 Commits (3) - [`9fdc964`](https://github.com/documenso/documenso/commit/9fdc964c473da7a74bfeac3e211d7ccca380a6fd) fix: allow dates with and without time - [`7780c74`](https://github.com/documenso/documenso/commit/7780c746d754acfccfddbb8ca85cc5f16888f7ef) Merge branch 'main' into fix/date-formats - [`85996c3`](https://github.com/documenso/documenso/commit/85996c3800e017fd1d89d3b312cb988ab8e3bb14) chore: standardize date formats to use 24-hour time ### 📊 Changes **1 file changed** (+59 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/constants/date-formats.ts` (+59 -33) </details> ### 📄 Description ## Description This PR extends the date formatting options to include both date-only and date-time formats. - Added 6 new date-only format patterns to `VALID_DATE_FORMAT_VALUES` - Extended `DATE_FORMATS` array with 7 new date-only format options - Reorganized formats into two clear sections: date-time and date-only - Fixed duplicate key issues by adding `_TIME` suffix to date-time format keys where conflicts existed ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:32:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#2008
No description provided.