starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1977] [CLOSED] fix: added missing strings for localization #1970

New issue

Closed

opened 2026-02-26 20:31:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1977
Author: @mKoonrad
Created: 8/20/2025
Status: ❌ Closed

Base: main ← Head: fix/1975-missing-strings-for-translation

📝 Commits (10+)

4d44b85 Add missing tag
6aaf8eb Mark missing messages for i18n
f0d38ec npm run translate:extract
c5132bc Revert "npm run translate:extract"
c5e6c2c Revert "Mark missing messages for i18n"
05f3a98 Merge branch 'main' into fix/1975-missing-strings-for-translation
aec3071 Add missing tag
4fba260 Merge branch 'main' into fix/1975-missing-strings-for-translation
0dc16a8 Merge branch 'main' into fix/1975-missing-strings-for-translation
d7b92ea Merge branch 'main' into fix/1975-missing-strings-for-translation

📊 Changes

9 files changed (+73 additions, -26 deletions)

View changed files

📝 packages/ui/components/document/document-visibility-select.tsx (+17 -6)
📝 packages/ui/primitives/document-flow/add-settings.tsx (+1 -1)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/date-field.tsx (+9 -3)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/email-field.tsx (+9 -3)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/initials-field.tsx (+9 -3)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/name-field.tsx (+9 -3)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/number-field.tsx (+9 -3)
📝 packages/ui/primitives/document-flow/field-items-advanced-settings/text-field.tsx (+9 -3)
📝 packages/ui/primitives/template-flow/add-template-settings.tsx (+1 -1)

📄 Description

Description

I marked missing strings for localization.

I fixed all reported strings in issue #1975 except documenso/packages/lib/constants/i18n.ts file with supported language (German, Polish, Spanish etc). In this file I'm not sure how to fix. Any help would be appreciated.

Issue #1975

Changes Made

Added missing <Trans> tag or (msg``)

Testing Performed

Tested by command npm run translate:extract

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1977 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 8/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/1975-missing-strings-for-translation` --- ### 📝 Commits (10+) - [`4d44b85`](https://github.com/documenso/documenso/commit/4d44b85e05828708b7ea3680ed01e2c758678f59) Add missing <Trans> tag - [`6aaf8eb`](https://github.com/documenso/documenso/commit/6aaf8eb8e273c08e1b690488e826d29b5025abf7) Mark missing messages for i18n - [`f0d38ec`](https://github.com/documenso/documenso/commit/f0d38ecc490f3f78cc6e058044e164d50de26c0b) npm run translate:extract - [`c5132bc`](https://github.com/documenso/documenso/commit/c5132bc5f923a7bacbfa1270d4283d83251348b1) Revert "npm run translate:extract" - [`c5e6c2c`](https://github.com/documenso/documenso/commit/c5e6c2cd9d8c48a756d7afd29af58b7b629e9b6a) Revert "Mark missing messages for i18n" - [`05f3a98`](https://github.com/documenso/documenso/commit/05f3a987c04c040bc3c6b1cc9c1d6ab0630e556c) Merge branch 'main' into fix/1975-missing-strings-for-translation - [`aec3071`](https://github.com/documenso/documenso/commit/aec307181307bc2d0536749d46b9f78e783e0377) Add missing <Trans> tag - [`4fba260`](https://github.com/documenso/documenso/commit/4fba2603d8a3ecefb737bb85f1f508ea5dcbeb95) Merge branch 'main' into fix/1975-missing-strings-for-translation - [`0dc16a8`](https://github.com/documenso/documenso/commit/0dc16a8bec73a4634d066c1bda88c54d24cc1b44) Merge branch 'main' into fix/1975-missing-strings-for-translation - [`d7b92ea`](https://github.com/documenso/documenso/commit/d7b92eaccfcbeed0a83b06b9b53971ebffed6adf) Merge branch 'main' into fix/1975-missing-strings-for-translation ### 📊 Changes **9 files changed** (+73 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/components/document/document-visibility-select.tsx` (+17 -6) 📝 `packages/ui/primitives/document-flow/add-settings.tsx` (+1 -1) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/date-field.tsx` (+9 -3) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/email-field.tsx` (+9 -3) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/initials-field.tsx` (+9 -3) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/name-field.tsx` (+9 -3) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/number-field.tsx` (+9 -3) 📝 `packages/ui/primitives/document-flow/field-items-advanced-settings/text-field.tsx` (+9 -3) 📝 `packages/ui/primitives/template-flow/add-template-settings.tsx` (+1 -1) </details> ### 📄 Description ## Description I marked missing strings for localization. I fixed all reported strings in issue #1975 except [documenso/packages/lib/constants/i18n.ts](https://github.com/documenso/documenso/blob/231ef9c27e1bd07668d9b0db07129e416d437ac1/packages/lib/constants/i18n.ts) file with supported language (German, Polish, Spanish etc). In this file I'm not sure how to fix. Any help would be appreciated. ## Related Issue Issue #1975 ## Changes Made - Added missing `<Trans>` tag or `(msg``)` ## Testing Performed   - Tested by command npm run translate:extract ## Checklist   - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1970

No description provided.

Rows
Columns