[PR #1952] [CLOSED] feat: add timestamp server for signPdf #1955

Closed
opened 2026-02-26 20:31:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1952
Author: @svetch
Created: 8/8/2025
Status: Closed

Base: mainHead: main


📝 Commits (3)

📊 Changes

12 files changed (+14 additions, -4 deletions)

View changed files

📝 .env.example (+2 -0)
📝 .github/workflows/e2e-tests.yml (+1 -0)
📝 apps/documentation/pages/developers/self-hosting/how-to.mdx (+1 -0)
📝 apps/documentation/pages/developers/self-hosting/signing-certificate.mdx (+1 -0)
📝 docker/README.md (+1 -0)
📝 docker/production/compose.yml (+1 -0)
📝 docker/testing/compose.yml (+1 -0)
📝 packages/signing/transports/google-cloud-hsm.ts (+1 -0)
📝 packages/signing/transports/local-cert.ts (+1 -0)
📝 packages/tsconfig/process-env.d.ts (+1 -0)
📝 render.yaml (+2 -0)
📝 turbo.json (+1 -4)

📄 Description

Description

Adds an optional timestamp server environment variable for configure timestamp server.

Changes Made

pass the NEXT_PRIVATE_SIGNING_TIMESTAMP_SERVER environment variable to signWithP12 and signWithGCloud

Testing Performed

  • Tested timestamping with a public timestamp server and also with auth

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1952 **Author:** [@svetch](https://github.com/svetch) **Created:** 8/8/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`6749a37`](https://github.com/documenso/documenso/commit/6749a374c2e9340cbf242b46f5a4c8572724b83b) feat: add timestamp server for signPdf - [`58cb3be`](https://github.com/documenso/documenso/commit/58cb3bebc4e7bc542c4d7fad1a65b61994af343a) chore: udpate docs - [`27dccb6`](https://github.com/documenso/documenso/commit/27dccb65efffba99b9c67190e7d29b01cbbd4c81) Update turbo.json ### 📊 Changes **12 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+2 -0) 📝 `.github/workflows/e2e-tests.yml` (+1 -0) 📝 `apps/documentation/pages/developers/self-hosting/how-to.mdx` (+1 -0) 📝 `apps/documentation/pages/developers/self-hosting/signing-certificate.mdx` (+1 -0) 📝 `docker/README.md` (+1 -0) 📝 `docker/production/compose.yml` (+1 -0) 📝 `docker/testing/compose.yml` (+1 -0) 📝 `packages/signing/transports/google-cloud-hsm.ts` (+1 -0) 📝 `packages/signing/transports/local-cert.ts` (+1 -0) 📝 `packages/tsconfig/process-env.d.ts` (+1 -0) 📝 `render.yaml` (+2 -0) 📝 `turbo.json` (+1 -4) </details> ### 📄 Description ## Description Adds an optional timestamp server environment variable for configure timestamp server. ## Related Issue ## Changes Made pass the `NEXT_PRIVATE_SIGNING_TIMESTAMP_SERVER` environment variable to signWithP12 and signWithGCloud ## Testing Performed - Tested timestamping with a public timestamp server and also with auth ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:31:48 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1955
No description provided.