starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1944] [MERGED] fix: send signing request email after the document status is updated #1949

New issue

Closed

opened 2026-02-26 20:31:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1944
Author: @samuel-cglg
Created: 8/6/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @Mythie

Base: main ← Head: fix-send-signing-requested-email

📝 Commits (2)

57de274 fix: send signing request email after the document status is updated
f37944a Merge branch 'main' into fix-send-signing-requested-email

📊 Changes

1 file changed (+27 additions, -27 deletions)

View changed files

📝 packages/lib/server-only/document/send-document.tsx (+27 -27)

📄 Description

Description

When sending a document for signing, emails for recipients are sent before the document status is updated.
In this case, the job "send.signing.requested.email" fails because it cannot find the document with a PENDING status.
In our self hosted instance, it generates ~10 errors in the logs (from this background job) every time a document is sent (we are using a LocalJobProvider, not inngest for background tasks).

none

Changes Made

When sending a document, the background job "send.signing.requested.email" is created after the document status is set to PENDING.

Testing Performed

Tested in local: the document is created as usual, the email notification is send and no error are found in the logs.

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1944 **Author:** [@samuel-cglg](https://github.com/samuel-cglg) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix-send-signing-requested-email` --- ### 📝 Commits (2) - [`57de274`](https://github.com/documenso/documenso/commit/57de274ed20f89f9e832198e6b56b1eadc571f99) fix: send signing request email after the document status is updated - [`f37944a`](https://github.com/documenso/documenso/commit/f37944ad9d18bb476d1c55d3fe7923ce803f6768) Merge branch 'main' into fix-send-signing-requested-email ### 📊 Changes **1 file changed** (+27 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `packages/lib/server-only/document/send-document.tsx` (+27 -27) </details> ### 📄 Description ## Description When sending a document for signing, emails for recipients are sent before the document status is updated. In this case, the job "send.signing.requested.email" fails because it cannot find the document with a PENDING status. In our self hosted instance, it generates ~10 errors in the logs (from this background job) every time a document is sent (we are using a `LocalJobProvider`, not inngest for background tasks). ## Related Issue none ## Changes Made When sending a document, the background job "send.signing.requested.email" is created after the document status is set to PENDING. ## Testing Performed Tested in local: the document is created as usual, the email notification is send and no error are found in the logs. ## Checklist   - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:48 +03:00

[PR #1949] [MERGED] chore: extract translations #1953

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1949

No description provided.

Rows
Columns