[PR #1938] [CLOSED] fix: strings improvements #1942

New issue

Closed

opened 2026-02-26 20:31:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1938
Author: @mKoonrad
Created: 8/4/2025
Status: ❌ Closed

Base: main ← Head: fix-strings

📝 Commits (10+)

96bba0e Removed extra space before string
f7e3507 Added plural for string
3d3a252 String unification
6d34e73 Missing dot
7f00e8f Added plural
6357eb3 Delete dot from link
d05218d Added plural
d7bd18e Create account button clarification
3c7dd62 Code as in text above
c8756a1 Delete dot in link

📊 Changes

30 files changed (+129 additions, -58 deletions)

View changed files

📝 apps/remix/app/components/dialogs/organisation-member-update-dialog.tsx (+1 -2)
📝 apps/remix/app/components/dialogs/team-member-update-dialog.tsx (+1 -1)
📝 apps/remix/app/components/dialogs/template-direct-link-dialog.tsx (+1 -1)
📝 apps/remix/app/components/forms/2fa/enable-authenticator-app-dialog.tsx (+1 -1)
📝 apps/remix/app/components/forms/document-preferences-form.tsx (+1 -1)
📝 apps/remix/app/components/forms/editor/editor-field-generic-field-forms.tsx (+3 -3)
📝 apps/remix/app/components/forms/signup.tsx (+1 -1)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx (+36 -7)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx (+1 -1)
📝 apps/remix/app/components/general/document/document-certificate-qr-view.tsx (+2 -2)
📝 apps/remix/app/components/general/document/document-drop-zone-wrapper.tsx (+1 -1)
📝 apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx (+2 -2)
📝 apps/remix/app/components/general/template/template-drop-zone-wrapper.tsx (+1 -1)
📝 apps/remix/app/components/tables/settings-security-passkey-table-actions.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.$id._index.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/settings.email.tsx (+1 -1)
📝 packages/app-tests/e2e/user/auth-flow.spec.ts (+1 -1)

...and 10 more files

📄 Description

Description

I fixed some strings for better localization process. As active translator, I could prepare PR with small message improvements, like adding missing plurals.

Changes Made

Typos
Added plurals
Strings format improvements

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1938 **Author:** [@mKoonrad](https://github.com/mKoonrad) **Created:** 8/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-strings` --- ### 📝 Commits (10+) - [`96bba0e`](https://github.com/documenso/documenso/commit/96bba0e0ca19b6d7f39db173f9f677883163df63) Removed extra space before string - [`f7e3507`](https://github.com/documenso/documenso/commit/f7e35074e80a56c4428a508d6aa1469e409f0713) Added plural for string - [`3d3a252`](https://github.com/documenso/documenso/commit/3d3a252d871556e0fa2dc727a2580eecea6f005c) String unification - [`6d34e73`](https://github.com/documenso/documenso/commit/6d34e737bf41fbbea54f1b058d3f138b19b24767) Missing dot - [`7f00e8f`](https://github.com/documenso/documenso/commit/7f00e8fa8c0a16d12520dd2ac2dc29e939d7feaf) Added plural - [`6357eb3`](https://github.com/documenso/documenso/commit/6357eb3aa8f6fa71fb81f1ef25d487b5e3c101cc) Delete dot from link - [`d05218d`](https://github.com/documenso/documenso/commit/d05218dc248874b332c9290027fdb134a5c57755) Added plural - [`d7bd18e`](https://github.com/documenso/documenso/commit/d7bd18e5ff75159b3830dabf039afbfdf0828a90) Create account button clarification - [`3c7dd62`](https://github.com/documenso/documenso/commit/3c7dd62f6764859f8c18e1ee1ba83bdcfbf32fd9) Code as in text above - [`c8756a1`](https://github.com/documenso/documenso/commit/c8756a1eade75d713f8cf1591c6c7205df72d4b2) Delete dot in link ### 📊 Changes **30 files changed** (+129 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/organisation-member-update-dialog.tsx` (+1 -2) 📝 `apps/remix/app/components/dialogs/team-member-update-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/dialogs/template-direct-link-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/forms/2fa/enable-authenticator-app-dialog.tsx` (+1 -1) 📝 `apps/remix/app/components/forms/document-preferences-form.tsx` (+1 -1) 📝 `apps/remix/app/components/forms/editor/editor-field-generic-field-forms.tsx` (+3 -3) 📝 `apps/remix/app/components/forms/signup.tsx` (+1 -1) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view-v1.tsx` (+36 -7) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view-v2.tsx` (+1 -1) 📝 `apps/remix/app/components/general/document/document-certificate-qr-view.tsx` (+2 -2) 📝 `apps/remix/app/components/general/document/document-drop-zone-wrapper.tsx` (+1 -1) 📝 `apps/remix/app/components/general/envelope-editor/envelope-editor-settings-dialog.tsx` (+2 -2) 📝 `apps/remix/app/components/general/template/template-drop-zone-wrapper.tsx` (+1 -1) 📝 `apps/remix/app/components/tables/settings-security-passkey-table-actions.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.branding.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.document.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.$id._index.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/settings.email.tsx` (+1 -1) 📝 `packages/app-tests/e2e/user/auth-flow.spec.ts` (+1 -1) _...and 10 more files_ </details> ### 📄 Description ## Description I fixed some strings for better localization process. As active translator, I could prepare PR with small message improvements, like adding missing plurals. ## Changes Made - Typos - Added plurals - Strings format improvements ## Checklist  - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:45 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1942

No description provided.

Rows
Columns