[PR #1934] [MERGED] fix: add missing email reply validation #1939

New issue

Closed

opened 2026-02-26 20:31:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1934
Author: @dguyen
Created: 8/1/2025
Status: ✅ Merged
Merged: 8/1/2025
Merged by: @Mythie

Base: main ← Head: fix/missing-reply-to-email-validations

📝 Commits (1)

b6067b6 fix: add missing email reply validation

📊 Changes

21 files changed (+28 additions, -21 deletions)

View changed files

📝 apps/remix/app/components/general/document/document-edit-form.tsx (+1 -1)
📝 apps/remix/app/components/general/template/template-edit-form.tsx (+1 -0)
📝 apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email-domains.$id.tsx (+1 -1)
📝 packages/lib/jobs/definitions/emails/send-document-cancelled-emails.handler.ts (+1 -1)
📝 packages/lib/jobs/definitions/emails/send-recipient-signed-email.handler.ts (+1 -1)
📝 packages/lib/jobs/definitions/emails/send-rejection-emails.handler.ts (+1 -1)
📝 packages/lib/jobs/definitions/emails/send-signing-email.handler.ts (+1 -1)
📝 packages/lib/server-only/document/delete-document.ts (+1 -1)
📝 packages/lib/server-only/document/resend-document.ts (+1 -1)
📝 packages/lib/server-only/document/send-completed-email.ts (+1 -1)
📝 packages/lib/server-only/document/send-delete-email.ts (+1 -1)
📝 packages/lib/server-only/document/send-pending-email.ts (+1 -1)
📝 packages/lib/server-only/document/super-delete-document.ts (+1 -1)
📝 packages/lib/server-only/email/get-email-context.ts (+2 -2)
📝 packages/lib/server-only/recipient/delete-document-recipient.ts (+1 -1)
📝 packages/lib/server-only/recipient/set-document-recipients.ts (+1 -1)
📝 packages/trpc/server/document-router/schema.ts (+1 -1)
📝 packages/trpc/server/document-router/update-document.types.ts (+1 -1)
📝 packages/trpc/server/template-router/schema.ts (+1 -1)
📝 packages/ui/primitives/document-flow/add-subject.types.ts (+4 -1)

...and 1 more files

📄 Description

Description

General fixes to the email domain features

Changes made:

Add "email" validation for "Reply-To email" fields
Fix issue where you can't remove the "Reply-To" email after it's set
Fix issue where setting the "Sender email" back to Documenso would still send using the org/team pref

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1934 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 8/1/2025 **Status:** ✅ Merged **Merged:** 8/1/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/missing-reply-to-email-validations` --- ### 📝 Commits (1) - [`b6067b6`](https://github.com/documenso/documenso/commit/b6067b638787388e0d7bc903afde5c43dae2f174) fix: add missing email reply validation ### 📊 Changes **21 files changed** (+28 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document/document-edit-form.tsx` (+1 -1) 📝 `apps/remix/app/components/general/template/template-edit-form.tsx` (+1 -0) 📝 `apps/remix/app/routes/_authenticated+/o.$orgUrl.settings.email-domains.$id.tsx` (+1 -1) 📝 `packages/lib/jobs/definitions/emails/send-document-cancelled-emails.handler.ts` (+1 -1) 📝 `packages/lib/jobs/definitions/emails/send-recipient-signed-email.handler.ts` (+1 -1) 📝 `packages/lib/jobs/definitions/emails/send-rejection-emails.handler.ts` (+1 -1) 📝 `packages/lib/jobs/definitions/emails/send-signing-email.handler.ts` (+1 -1) 📝 `packages/lib/server-only/document/delete-document.ts` (+1 -1) 📝 `packages/lib/server-only/document/resend-document.ts` (+1 -1) 📝 `packages/lib/server-only/document/send-completed-email.ts` (+1 -1) 📝 `packages/lib/server-only/document/send-delete-email.ts` (+1 -1) 📝 `packages/lib/server-only/document/send-pending-email.ts` (+1 -1) 📝 `packages/lib/server-only/document/super-delete-document.ts` (+1 -1) 📝 `packages/lib/server-only/email/get-email-context.ts` (+2 -2) 📝 `packages/lib/server-only/recipient/delete-document-recipient.ts` (+1 -1) 📝 `packages/lib/server-only/recipient/set-document-recipients.ts` (+1 -1) 📝 `packages/trpc/server/document-router/schema.ts` (+1 -1) 📝 `packages/trpc/server/document-router/update-document.types.ts` (+1 -1) 📝 `packages/trpc/server/template-router/schema.ts` (+1 -1) 📝 `packages/ui/primitives/document-flow/add-subject.types.ts` (+4 -1) _...and 1 more files_ </details> ### 📄 Description ## Description General fixes to the email domain features Changes made: - Add "email" validation for "Reply-To email" fields - Fix issue where you can't remove the "Reply-To" email after it's set - Fix issue where setting the "Sender email" back to Documenso would still send using the org/team pref --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:44 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:45 +03:00

[PR #1939] [MERGED] fix: correctly set stripe customer names #1943

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1939

No description provided.

Rows
Columns