[PR #1917] [CLOSED] feat: document 2fa #1928

New issue

Closed

opened 2026-02-26 20:31:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1917
Author: @ephraimduncan
Created: 7/22/2025
Status: ❌ Closed

Base: main ← Head: feat/document-2fa-redo

📝 Commits (4)

43810c4 feat: document 2fa
04e3e1e fix: remove multiselect for auth select
e52af33 Merge branch 'main' into feat/document-2fa-redo
35410e1 fix: merge conflicts

📊 Changes

30 files changed (+833 additions, -198 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx (+218 -66)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx (+22 -3)
📝 apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx (+14 -3)
📝 apps/remix/app/components/general/document-signing/document-signing-form.tsx (+24 -5)
📝 apps/remix/app/components/general/document-signing/document-signing-page-view.tsx (+3 -0)
📝 apps/remix/app/components/general/template/template-edit-form.tsx (+1 -1)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates._index.tsx (+1 -1)
📝 apps/remix/app/routes/_recipient+/d.$token+/_index.tsx (+1 -0)
📝 apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx (+10 -0)
📝 apps/remix/app/routes/embed+/_v0+/direct.$url.tsx (+14 -2)
📝 apps/remix/app/routes/embed+/_v0+/sign.$url.tsx (+5 -0)
📝 apps/remix/app/routes/embed+/v1+/multisign+/_index.tsx (+5 -1)
📝 packages/app-tests/e2e/document-flow/settings-step.spec.ts (+2 -2)
📝 packages/app-tests/e2e/templates-flow/template-settings-step.spec.ts (+2 -2)
➕ packages/email/template-components/template-verification-code.tsx (+43 -0)
➕ packages/email/templates/verification-code.tsx (+62 -0)
➕ packages/lib/server-only/2fa/send-email-verification.ts (+120 -0)
📝 packages/lib/server-only/document/update-document.ts (+1 -9)
📝 packages/lib/server-only/field/sign-field-with-token.ts (+24 -10)
📝 packages/lib/server-only/organisation/get-organisation-claims.ts (+20 -0)

...and 10 more files

📄 Description

Demo

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1917 **Author:** [@ephraimduncan](https://github.com/ephraimduncan) **Created:** 7/22/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/document-2fa-redo` --- ### 📝 Commits (4) - [`43810c4`](https://github.com/documenso/documenso/commit/43810c4357ab8982de09a7960223da80395511b8) feat: document 2fa - [`04e3e1e`](https://github.com/documenso/documenso/commit/04e3e1eeb9d8e3169f1c7e2ad1173a277ead7a4e) fix: remove multiselect for auth select - [`e52af33`](https://github.com/documenso/documenso/commit/e52af336b4ec68fbdbfb25ccaea370a8dec0d671) Merge branch 'main' into feat/document-2fa-redo - [`35410e1`](https://github.com/documenso/documenso/commit/35410e100eca4d8aa0b0653dbf126388d470a614) fix: merge conflicts ### 📊 Changes **30 files changed** (+833 additions, -198 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-2fa.tsx` (+218 -66) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-dialog.tsx` (+22 -3) 📝 `apps/remix/app/components/general/document-signing/document-signing-auth-provider.tsx` (+14 -3) 📝 `apps/remix/app/components/general/document-signing/document-signing-form.tsx` (+24 -5) 📝 `apps/remix/app/components/general/document-signing/document-signing-page-view.tsx` (+3 -0) 📝 `apps/remix/app/components/general/template/template-edit-form.tsx` (+1 -1) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates._index.tsx` (+1 -1) 📝 `apps/remix/app/routes/_recipient+/d.$token+/_index.tsx` (+1 -0) 📝 `apps/remix/app/routes/_recipient+/sign.$token+/_index.tsx` (+10 -0) 📝 `apps/remix/app/routes/embed+/_v0+/direct.$url.tsx` (+14 -2) 📝 `apps/remix/app/routes/embed+/_v0+/sign.$url.tsx` (+5 -0) 📝 `apps/remix/app/routes/embed+/v1+/multisign+/_index.tsx` (+5 -1) 📝 `packages/app-tests/e2e/document-flow/settings-step.spec.ts` (+2 -2) 📝 `packages/app-tests/e2e/templates-flow/template-settings-step.spec.ts` (+2 -2) ➕ `packages/email/template-components/template-verification-code.tsx` (+43 -0) ➕ `packages/email/templates/verification-code.tsx` (+62 -0) ➕ `packages/lib/server-only/2fa/send-email-verification.ts` (+120 -0) 📝 `packages/lib/server-only/document/update-document.ts` (+1 -9) 📝 `packages/lib/server-only/field/sign-field-with-token.ts` (+24 -10) 📝 `packages/lib/server-only/organisation/get-organisation-claims.ts` (+20 -0) _...and 10 more files_ </details> ### 📄 Description ## Demo ### Document and Template Setting https://github.com/user-attachments/assets/75c647bb-0ae6-4222-b836-ecebadab383e ### Emailing a given 2FA Token if a user does not have a 2FA secret created https://github.com/user-attachments/assets/45fb53d5-dcd1-481d-bd69-3b90479cd81e ### Emailing a given 2FA Token if a user has a 2FA secret created https://github.com/user-attachments/assets/b981b279-b960-4df9-b74a-70a0b0c83832 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1928

No description provided.

Rows
Columns