starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1915] [MERGED] fix: clicking on tooltip icon submit parent form #1926

New issue

Closed

opened 2026-02-26 20:31:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1915
Author: @samuel-cglg
Created: 7/21/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @dguyen

Base: main ← Head: fix-tooltip-button

📝 Commits (1)

e2e8a89 fix: clicking on tooltip icon submit parent form

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/ui/components/document/document-signature-settings-tooltip.tsx (+1 -1)

📄 Description

Description

In "Organization Settings" and "Team Settings" preferences pages, a click on the tooltip information icon submit the page form, which is unexpected.

To reproduce this issue:

navigate to organization settings preferences page
next to the form input label "Default Signature Settings", click on the information icon (circled "i")
the page form is submitted (you get the popup "Document preferences updated")

Changes Made

Changed the tooltip icon button type to "button", as it is done in some other places in the project.

Testing Performed

Tested on Safari and Firefox (macOS).

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1915 **Author:** [@samuel-cglg](https://github.com/samuel-cglg) **Created:** 7/21/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix-tooltip-button` --- ### 📝 Commits (1) - [`e2e8a89`](https://github.com/documenso/documenso/commit/e2e8a89a775bcc51611f14c412da62c72d224282) fix: clicking on tooltip icon submit parent form ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/components/document/document-signature-settings-tooltip.tsx` (+1 -1) </details> ### 📄 Description ## Description In "Organization Settings" and "Team Settings" preferences pages, a click on the tooltip information icon submit the page form, which is unexpected. <img width="1005" height="787" alt="Screenshot 2025-07-21 à 11 48 49" src="https://github.com/user-attachments/assets/1604e501-5d6d-4743-9085-adaa015d1b0f" /> To reproduce this issue: - navigate to organization settings preferences page - next to the form input label "Default Signature Settings", click on the information icon (circled "i") - the page form is submitted (you get the popup "Document preferences updated") ## Related Issue ## Changes Made Changed the tooltip icon button type to "button", as it is done in some other places in the project. ## Testing Performed Tested on Safari and Firefox (macOS). ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:43 +03:00

[PR #1926] [CLOSED] feat: Swedish translation #1935

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1926

No description provided.

Rows
Columns