starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 22:05:59 +03:00

[PR #1909] [CLOSED] feat: enable the text and annotation layer in the pdf-viewer #1923

New issue

Closed

opened 2026-02-26 20:31:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1909
Author: @atomdeveloper
Created: 7/17/2025
Status: ❌ Closed

Base: main ← Head: feat/enable-text-and-annotation-layer

📝 Commits (1)

2b75219 feat: enable the text and annotation layer in the pdf-viewer

📊 Changes

1 file changed (+0 additions, -2 deletions)

View changed files

📝 packages/ui/primitives/pdf-viewer.tsx (+0 -2)

📄 Description

Description

Hey this is my first pull request here, hopefully I didn't miss anything. This pull request removes the two lines that were disabling the textLayer and the annotationLayer in the react-pdf document viewer. Our customers have requested the ability to select text and click links in the PDF's they receive to sign.

Changes Made

Enable the textLayer and annotationLayer which were disabled, the default is enabled so removing the two lines enables both features

Testing Performed

Tested in Chrome and Firefox manually and all related e2e tests passed as well. All of the signing widgets appear on top of the PDF so links do not interfere with signing or any of that functionality.

Checklist

I have tested these changes locally and they work as expected.
I have followed the project's coding style guidelines.

Additional Notes

These features were disabled without any comments but I understand they may have been disabled for a reason. If the textLayer and annotationLayer being enabled pose security threaths or there is a reason for them being disabled I am fine with that. I would just like a reason to give customers who are asking for this functionality. Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1909 **Author:** [@atomdeveloper](https://github.com/atomdeveloper) **Created:** 7/17/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/enable-text-and-annotation-layer` --- ### 📝 Commits (1) - [`2b75219`](https://github.com/documenso/documenso/commit/2b75219101df213c59545ee13ebdb8b3d3c8a94a) feat: enable the text and annotation layer in the pdf-viewer ### 📊 Changes **1 file changed** (+0 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/ui/primitives/pdf-viewer.tsx` (+0 -2) </details> ### 📄 Description ## Description Hey this is my first pull request here, hopefully I didn't miss anything. This pull request removes the two lines that were disabling the textLayer and the annotationLayer in the react-pdf document viewer. Our customers have requested the ability to select text and click links in the PDF's they receive to sign. ## Changes Made - Enable the textLayer and annotationLayer which were disabled, the default is enabled so removing the two lines enables both features ## Testing Performed Tested in Chrome and Firefox manually and all related e2e tests passed as well. All of the signing widgets appear on top of the PDF so links do not interfere with signing or any of that functionality. ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have followed the project's coding style guidelines. ## Additional Notes These features were disabled without any comments but I understand they may have been disabled for a reason. If the textLayer and annotationLayer being enabled pose security threaths or there is a reason for them being disabled I am fine with that. I would just like a reason to give customers who are asking for this functionality. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:40 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:43 +03:00

[PR #1923] [MERGED] feat: implement recipients autosuggestions #1933

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1923

No description provided.

Rows
Columns