starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 13:55:59 +03:00

[PR #1903] [CLOSED] feat: usb-token and http signing method #1920

New issue

Closed

opened 2026-02-26 20:31:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1903
Author: @marentdev
Created: 7/15/2025
Status: ❌ Closed

Base: main ← Head: feat-usb-token-and-http

📝 Commits (4)

651e03c feat: usb-token and http signing method
36502d8 Merge branch 'main' into feat-usb-token-and-http
311a88f feat: add possibility to send pdf to http sign without placeholder
befa5b6 Merge branch 'main' into feat-usb-token-and-http

📊 Changes

4 files changed (+113 additions, -1 deletions)

View changed files

📝 .env.example (+17 -1)
📝 packages/signing/index.ts (+4 -0)
➕ packages/signing/transports/http.ts (+33 -0)
➕ packages/signing/transports/usb-token.ts (+59 -0)

📄 Description

THIS PR NEED TO BE REVIEW FIRST => https://github.com/documenso/pdf-sign/pull/3

Description

Added the ability to sign pdf document with usb-token or via http request to a server

#1642
#1687

Changes Made

Adding USB-TOKEN and http request pdf sign method from @documenso/pdf-sign package (pr open)

Testing Performed

I tested to sign a pdf and waiting him to be "completed" for every new method

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1903 **Author:** [@marentdev](https://github.com/marentdev) **Created:** 7/15/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat-usb-token-and-http` --- ### 📝 Commits (4) - [`651e03c`](https://github.com/documenso/documenso/commit/651e03c03025947de6dcee5fb5f787dca3e6d22b) feat: usb-token and http signing method - [`36502d8`](https://github.com/documenso/documenso/commit/36502d89eac7dd2b1b20136a89435489139455b8) Merge branch 'main' into feat-usb-token-and-http - [`311a88f`](https://github.com/documenso/documenso/commit/311a88f2b2c2e28bb220ecea41826bf1dc7d9189) feat: add possibility to send pdf to http sign without placeholder - [`befa5b6`](https://github.com/documenso/documenso/commit/befa5b6029ea72db73bfa39564405f000972a5fa) Merge branch 'main' into feat-usb-token-and-http ### 📊 Changes **4 files changed** (+113 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+17 -1) 📝 `packages/signing/index.ts` (+4 -0) ➕ `packages/signing/transports/http.ts` (+33 -0) ➕ `packages/signing/transports/usb-token.ts` (+59 -0) </details> ### 📄 Description THIS PR NEED TO BE REVIEW FIRST => https://github.com/documenso/pdf-sign/pull/3 ## Description Added the ability to sign pdf document with usb-token or via http request to a server ## Related Issue #1642 #1687 ## Changes Made Adding USB-TOKEN and http request pdf sign method from @documenso/pdf-sign package (pr open) ## Testing Performed I tested to sign a pdf and waiting him to be "completed" for every new method ## Checklist - [x] I have tested these changes locally and they work as expected. - [x] I have added/updated tests that prove the effectiveness of these changes. - [x] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [x] I have addressed the code review feedback from the previous submission, if applicable. ## Additional Notes   --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:39 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:42 +03:00

[PR #1920] [MERGED] fix: correctly render new lines in text fields #1931

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1920

No description provided.

Rows
Columns