[PR #1898] [MERGED] fix: invalid folder queries #1913

New issue

Closed

opened 2026-02-26 20:31:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1898
Author: @dguyen
Created: 7/14/2025
Status: ✅ Merged
Merged: 7/16/2025
Merged by: @Mythie

Base: main ← Head: fix/invalid-folder-queries

📝 Commits (2)

368d6b6 fix: invalid folder queries
997dd56 fix: test

📊 Changes

20 files changed (+136 additions, -143 deletions)

View changed files

📝 apps/remix/app/components/dialogs/folder-delete-dialog.tsx (+2 -2)
📝 apps/remix/app/components/dialogs/folder-update-dialog.tsx (+40 -21)
📝 apps/remix/app/components/general/folder/folder-grid.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx (+2 -2)
📝 apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates.folders._index.tsx (+2 -2)
📝 packages/api/v1/implementation.ts (+0 -1)
📝 packages/app-tests/e2e/folders/team-account-folders.spec.ts (+2 -2)
📝 packages/lib/server-only/document/create-document.ts (+5 -2)
📝 packages/lib/server-only/field/delete-field.ts (+0 -1)
📝 packages/lib/server-only/field/update-field.ts (+0 -1)
📝 packages/lib/server-only/folder/delete-folder.ts (+5 -2)
📝 packages/lib/server-only/folder/move-folder.ts (+6 -2)
📝 packages/lib/server-only/folder/move-template-to-folder.ts (+36 -32)
📝 packages/lib/server-only/folder/pin-folder.ts (+5 -2)
📝 packages/lib/server-only/folder/unpin-folder.ts (+5 -2)
📝 packages/lib/server-only/folder/update-folder.ts (+5 -2)
➖ packages/lib/server-only/organisation/create-organisation-billing-portal.ts (+0 -47)
📝 packages/lib/server-only/webhooks/get-all-webhooks-by-event-trigger.ts (+6 -16)
➕ packages/prisma/migrations/20250714060452_update_folder_delete_cascade/migration.sql (+11 -0)
📝 packages/prisma/schema.prisma (+2 -2)

📄 Description

Description

Currently the majority of folder mutations only work if the user is the owner of the folder.

This means as a team member, you cannot:

Create documents in folders you don't own
Move folders
Pin/Unpin folders
Delete folders

Changes made

Move folder items to root instead of deleting them when a parent folder is deleted
Fix queries
Fix missing translations
UI changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1898 **Author:** [@dguyen](https://github.com/dguyen) **Created:** 7/14/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/invalid-folder-queries` --- ### 📝 Commits (2) - [`368d6b6`](https://github.com/documenso/documenso/commit/368d6b6ed69a9700b5ca396df561f6d7f64a803b) fix: invalid folder queries - [`997dd56`](https://github.com/documenso/documenso/commit/997dd56a0c7592cda10e6feedc831b4aa70e2e99) fix: test ### 📊 Changes **20 files changed** (+136 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/folder-delete-dialog.tsx` (+2 -2) 📝 `apps/remix/app/components/dialogs/folder-update-dialog.tsx` (+40 -21) 📝 `apps/remix/app/components/general/folder/folder-grid.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/documents.folders._index.tsx` (+2 -2) 📝 `apps/remix/app/routes/_authenticated+/t.$teamUrl+/templates.folders._index.tsx` (+2 -2) 📝 `packages/api/v1/implementation.ts` (+0 -1) 📝 `packages/app-tests/e2e/folders/team-account-folders.spec.ts` (+2 -2) 📝 `packages/lib/server-only/document/create-document.ts` (+5 -2) 📝 `packages/lib/server-only/field/delete-field.ts` (+0 -1) 📝 `packages/lib/server-only/field/update-field.ts` (+0 -1) 📝 `packages/lib/server-only/folder/delete-folder.ts` (+5 -2) 📝 `packages/lib/server-only/folder/move-folder.ts` (+6 -2) 📝 `packages/lib/server-only/folder/move-template-to-folder.ts` (+36 -32) 📝 `packages/lib/server-only/folder/pin-folder.ts` (+5 -2) 📝 `packages/lib/server-only/folder/unpin-folder.ts` (+5 -2) 📝 `packages/lib/server-only/folder/update-folder.ts` (+5 -2) ➖ `packages/lib/server-only/organisation/create-organisation-billing-portal.ts` (+0 -47) 📝 `packages/lib/server-only/webhooks/get-all-webhooks-by-event-trigger.ts` (+6 -16) ➕ `packages/prisma/migrations/20250714060452_update_folder_delete_cascade/migration.sql` (+11 -0) 📝 `packages/prisma/schema.prisma` (+2 -2) </details> ### 📄 Description ## Description Currently the majority of folder mutations only work if the user is the owner of the folder. This means as a team member, you cannot: - Create documents in folders you don't own - Move folders - Pin/Unpin folders - Delete folders ## Changes made - Move folder items to root instead of deleting them when a parent folder is deleted - Fix queries - Fix missing translations - UI changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:38 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1913

No description provided.

Rows
Columns