starred/documenso

Fork 0

mirror of https://github.com/documenso/documenso.git synced 2026-04-25 05:46:01 +03:00

[PR #1885] [MERGED] fix: sign-able readonly fields #1906

New issue

Closed

opened 2026-02-26 20:31:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 20:31:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1885
Author: @catalinpit
Created: 7/8/2025
Status: ✅ Merged
Merged: 7/10/2025
Merged by: @Mythie

Base: main ← Head: fix/signable-readonly-field

📝 Commits (4)

4c9f007 fix: signable readonly fields
72fcefb fix: fix: update checkbox and radio field to use isReadOnly for disabled state
e03e3e6 chore: remove server check
caf8465 fix: add server side readonly checks

📊 Changes

5 files changed (+39 additions, -8 deletions)

View changed files

📝 apps/remix/app/components/general/document-signing/document-signing-auto-sign.tsx (+1 -7)
📝 apps/remix/app/components/general/document-signing/document-signing-checkbox-field.tsx (+2 -1)
📝 apps/remix/app/components/general/document-signing/document-signing-radio-field.tsx (+3 -0)
➕ packages/lib/constants/autosign.ts (+8 -0)
📝 packages/lib/server-only/field/sign-field-with-token.ts (+25 -0)

📄 Description

Description

Fix the issue with read-only fields being sign-able by the user.

Changes Made

Change 1
Change 2
...

Testing Performed

Tested feature X in scenario Y.
Ran unit tests for component Z.
Tested on browsers A, B, and C.
...

Checklist

I have tested these changes locally and they work as expected.
I have added/updated tests that prove the effectiveness of these changes.
I have updated the documentation to reflect these changes, if applicable.
I have followed the project's coding style guidelines.
I have addressed the code review feedback from the previous submission, if applicable.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1885 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/10/2025 **Merged by:** [@Mythie](https://github.com/Mythie) **Base:** `main` ← **Head:** `fix/signable-readonly-field` --- ### 📝 Commits (4) - [`4c9f007`](https://github.com/documenso/documenso/commit/4c9f0072c69d05b66b262ea4f5e4960618e06f76) fix: signable readonly fields - [`72fcefb`](https://github.com/documenso/documenso/commit/72fcefbcc8ecd6959328656ef6f53582aeb77b91) fix: fix: update checkbox and radio field to use isReadOnly for disabled state - [`e03e3e6`](https://github.com/documenso/documenso/commit/e03e3e68236383f6aa3f441a540180f11ccc8213) chore: remove server check - [`caf8465`](https://github.com/documenso/documenso/commit/caf846596c73344239e796a90d4bf5c4dd9d1020) fix: add server side readonly checks ### 📊 Changes **5 files changed** (+39 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/general/document-signing/document-signing-auto-sign.tsx` (+1 -7) 📝 `apps/remix/app/components/general/document-signing/document-signing-checkbox-field.tsx` (+2 -1) 📝 `apps/remix/app/components/general/document-signing/document-signing-radio-field.tsx` (+3 -0) ➕ `packages/lib/constants/autosign.ts` (+8 -0) 📝 `packages/lib/server-only/field/sign-field-with-token.ts` (+25 -0) </details> ### 📄 Description ## Description Fix the issue with read-only fields being sign-able by the user. ## Related Issue   ## Changes Made   - Change 1 - Change 2 - ... ## Testing Performed   - Tested feature X in scenario Y. - Ran unit tests for component Z. - Tested on browsers A, B, and C. - ... ## Checklist - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 20:31:36 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 20:31:40 +03:00

[PR #1906] [CLOSED] feat: add pt translations #1921

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/documenso#1906

No description provided.

Rows
Columns