[PR #1884] [MERGED] fix: handle unauthorized document move error #1904

Closed
opened 2026-02-26 20:31:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/documenso/documenso/pull/1884
Author: @catalinpit
Created: 7/8/2025
Status: Merged
Merged: 7/16/2025
Merged by: @dguyen

Base: mainHead: fix/recipient-move-document


📝 Commits (6)

  • 2735197 fix: handle unauthorized document move error
  • a530a14 Merge branch 'main' into fix/recipient-move-document
  • c6456ae chore: implement feedback
  • 0b2be6f chore: implement feedback
  • 37e6260 Merge branch 'main' into fix/recipient-move-document
  • 27a84de fix: remove redundant statement

📊 Changes

2 files changed (+11 additions, -1 deletions)

View changed files

📝 apps/remix/app/components/dialogs/document-move-to-folder-dialog.tsx (+10 -0)
📝 apps/remix/app/components/tables/documents-table-action-dropdown.tsx (+1 -1)

📄 Description

Description

  • Adds error handling for unauthorized document moving in the DocumentMoveToFolderDialog component.
  • Displays a toast notification when the recipient tries to move a document.
  • Updates the DocumentsTableActionDropdown to disable the move option if the user is not the owner of the document.
  • Ensures server-side validation checks for user permissions before moving documents.

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/documenso/documenso/pull/1884 **Author:** [@catalinpit](https://github.com/catalinpit) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/16/2025 **Merged by:** [@dguyen](https://github.com/dguyen) **Base:** `main` ← **Head:** `fix/recipient-move-document` --- ### 📝 Commits (6) - [`2735197`](https://github.com/documenso/documenso/commit/27351972d998d9309a5039ec3d7756105960a2f9) fix: handle unauthorized document move error - [`a530a14`](https://github.com/documenso/documenso/commit/a530a1409952c0467323ba6e9c37d76a69c67258) Merge branch 'main' into fix/recipient-move-document - [`c6456ae`](https://github.com/documenso/documenso/commit/c6456ae7a6d70377e134b49fe8d917a777cf37c6) chore: implement feedback - [`0b2be6f`](https://github.com/documenso/documenso/commit/0b2be6f6839a7becd8834f5c035f630798f482d7) chore: implement feedback - [`37e6260`](https://github.com/documenso/documenso/commit/37e6260829d61e320ac8202257a5b76baca17a80) Merge branch 'main' into fix/recipient-move-document - [`27a84de`](https://github.com/documenso/documenso/commit/27a84de3992843cbc4779fe15fa5584bed30790d) fix: remove redundant statement ### 📊 Changes **2 files changed** (+11 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `apps/remix/app/components/dialogs/document-move-to-folder-dialog.tsx` (+10 -0) 📝 `apps/remix/app/components/tables/documents-table-action-dropdown.tsx` (+1 -1) </details> ### 📄 Description ## Description - Adds error handling for unauthorized document moving in the `DocumentMoveToFolderDialog` component. - Displays a toast notification when the recipient tries to move a document. - Updates the `DocumentsTableActionDropdown` to disable the move option if the user is not the owner of the document. - Ensures server-side validation checks for user permissions before moving documents. ## Checklist <!--- Please check the boxes that apply to this pull request. --> <!--- You can add or remove items as needed. --> - [x] I have tested these changes locally and they work as expected. - [ ] I have added/updated tests that prove the effectiveness of these changes. - [ ] I have updated the documentation to reflect these changes, if applicable. - [x] I have followed the project's coding style guidelines. - [ ] I have addressed the code review feedback from the previous submission, if applicable. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 20:31:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/documenso#1904
No description provided.